Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2693303003: Implement CompilationUnitElement.lineInfo in MockCompilationUnitElement. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
Reviewers:
Paul Berry, pquitslund
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement CompilationUnitElement.lineInfo in MockCompilationUnitElement. R=paulberry@google.com, pquitslund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6e1725b0b2cc3a6e3beb51e25d6f04111aa1bc36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/front_end/lib/src/fasta/analyzer/mock_element.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scheglov
3 years, 10 months ago (2017-02-15 18:40:47 UTC) #1
pquitslund
FWIW: LGTM (and thanks!)
3 years, 10 months ago (2017-02-15 18:43:55 UTC) #3
Paul Berry
lgtm
3 years, 10 months ago (2017-02-15 19:21:06 UTC) #4
scheglov
3 years, 10 months ago (2017-02-15 19:22:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6e1725b0b2cc3a6e3beb51e25d6f04111aa1bc36 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698