Fix commit queue to actually abort on import error.

Fix commit queue to actually abort on import error.

BUG=306111
R=phajdan.jr@chromium.org,iannucci@chromium.org,vadimsh@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228037

[agable, 2013-10-10 21:52:10]

This will cause cq to abort in the face of failed imports, like we faced
yesterday.

[Paweł Hajdan Jr., 2013-10-10 23:04:33]

https://codereview.chromium.org/26933002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/26933002/diff/1/projects.py#newcode30
projects.py:30: ROOT_DIR = os.path.dirname(os.path.abspath(__file__))
While you're here, shouldn't ROOT_DIR be more like MY_DIR or CQ_ROOT_DIR?

https://codereview.chromium.org/26933002/diff/1/projects.py#newcode43
projects.py:43: 'Failed to find commit-queue-internal; will fail to start!')
I don't think this patch makes it actually fail to start.

https://codereview.chromium.org/26933002/diff/1/workdir/README
File workdir/README (right):

https://codereview.chromium.org/26933002/diff/1/workdir/README#newcode11
workdir/README:11: * .chromium_status_password file to be able to access the
chromium tree status
nit: This doesn't seem related, maybe make that a separate CL (small change, I
know)

[agable, 2013-10-10 23:21:05]

https://codereview.chromium.org/26933002/diff/1/projects.py
File projects.py (right):

https://codereview.chromium.org/26933002/diff/1/projects.py#newcode30
projects.py:30: ROOT_DIR = os.path.dirname(os.path.abspath(__file__))
On 2013/10/10 23:04:33, Paweł Hajdan Jr. wrote:
> While you're here, shouldn't ROOT_DIR be more like MY_DIR or CQ_ROOT_DIR?

It is the root of the repository...

https://codereview.chromium.org/26933002/diff/1/projects.py#newcode43
projects.py:43: 'Failed to find commit-queue-internal; will fail to start!')
On 2013/10/10 23:04:33, Paweł Hajdan Jr. wrote:
> I don't think this patch makes it actually fail to start.

Nope, but it didn't before either. CQ has never crashed when -internal isn't
preset, so it can be tested by external devs. Now at least it crashes when the
imports from -internal fail.

https://codereview.chromium.org/26933002/diff/1/workdir/README
File workdir/README (right):

https://codereview.chromium.org/26933002/diff/1/workdir/README#newcode11
workdir/README:11: * .chromium_status_password file to be able to access the
chromium tree status
On 2013/10/10 23:04:33, Paweł Hajdan Jr. wrote:
> nit: This doesn't seem related, maybe make that a separate CL (small change, I
> know)

I'll remove it if you like but it's hardly worth a change on it's own./

[agable, 2013-10-10 23:21:53]

Committed patchset #1 manually as r228037 (presubmit successful).