Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: test/cctest/test-api.cc

Issue 2693203003: Make CreationContext() not crash when there is no creation context. (Closed)
Patch Set: Rebase on top of other patch instead. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/api/remote-object-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 74f67d1910e656f1fee4fd852b47dad04f664cb7..21892f86d1b2a1a3c1690de783d35fa3f867a1ed 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -25974,7 +25974,7 @@ TEST(ObjectTemplatePerContextIntrinsics) {
object->Get(env.local(), v8_str("values")).ToLocalChecked());
auto fn = i::Handle<i::JSFunction>::cast(v8::Utils::OpenHandle(*values));
auto ctx = v8::Utils::OpenHandle(*env.local());
- CHECK_EQ(fn->GetCreationContext(), *ctx);
+ CHECK_EQ(*fn->GetCreationContext(), *ctx);
{
LocalContext env2;
@@ -25990,7 +25990,7 @@ TEST(ObjectTemplatePerContextIntrinsics) {
object2->Get(env2.local(), v8_str("values")).ToLocalChecked());
auto fn2 = i::Handle<i::JSFunction>::cast(v8::Utils::OpenHandle(*values2));
auto ctx2 = v8::Utils::OpenHandle(*env2.local());
- CHECK_EQ(fn2->GetCreationContext(), *ctx2);
+ CHECK_EQ(*fn2->GetCreationContext(), *ctx2);
}
}
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/api/remote-object-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698