src/api.cc - Issue 2693203003: Make CreationContext() not crash when there is no creation context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2693203003: Make CreationContext() not crash when there is no creation context. (Closed)

Patch Set: Rebase on top of other patch instead. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 817b39bb326fd967cc05cf89b21e8629da54d343..e5488e6508131fd7759faf5db467f727a00fe8f1 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -5001,8 +5001,7 @@ Local<v8::Object> v8::Object::Clone() {

Local<v8::Context> v8::Object::CreationContext() {

auto self = Utils::OpenHandle(this);

- auto context = handle(self->GetCreationContext());

- return Utils::ToLocal(context);

+ return Utils::ToLocal(self->GetCreationContext());

}

« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »