Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26932003: [Telemetry] Build and install memconsumer app. (Closed)

Created:
7 years, 2 months ago by frankf
Modified:
7 years, 2 months ago
Reviewers:
bulach, tonyg, qsr
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Build and install memconsumer app. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228410

Patch Set 1 #

Total comments: 2

Patch Set 2 : User friendly exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M build/all_android.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py View 1 2 chunks +9 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
frankf
7 years, 2 months ago (2013-10-11 00:37:53 UTC) #1
qsr
lgtm
7 years, 2 months ago (2013-10-11 08:03:34 UTC) #2
frankf
tonyg for OWNERS
7 years, 2 months ago (2013-10-11 18:47:50 UTC) #3
frankf
+bulach for OWNERS Please hit the cq if ok
7 years, 2 months ago (2013-10-12 01:22:08 UTC) #4
tonyg
lgtm https://codereview.chromium.org/26932003/diff/1/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py File tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py (right): https://codereview.chromium.org/26932003/diff/1/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py#newcode35 tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py:35: assert mem_consumer_path, 'Could not find memconsumer app.' We ...
7 years, 2 months ago (2013-10-12 01:58:16 UTC) #5
frankf
https://codereview.chromium.org/26932003/diff/1/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py File tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py (right): https://codereview.chromium.org/26932003/diff/1/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py#newcode35 tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py:35: assert mem_consumer_path, 'Could not find memconsumer app.' On 2013/10/12 ...
7 years, 2 months ago (2013-10-12 18:28:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26932003/9001
7 years, 2 months ago (2013-10-12 18:28:45 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-12 18:35:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/26932003/9001
7 years, 2 months ago (2013-10-13 00:50:27 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-13 18:33:40 UTC) #10
Message was sent while issue was closed. 
Change committed as 228410

Powered by Google App Engine
This is Rietveld 408576698