third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h - Issue 2693193002: [LayoutNG] A different approach to multi-col.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

Issue 2693193002: [LayoutNG] A different approach to multi-col. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_multi_column_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part_test.cc ('k') | third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

index bb33b0f1acc920d40815f6d07966e9a5bf4dc27e..274eb4eac615df0004744127860567e298ced0b2 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

@@ -28,7 +28,8 @@ class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragment {

out_of_flow_descendants,

Vector<NGStaticPosition> out_of_flow_positions,

Vector<Persistent<NGFloatingObject>>& unpositioned_floats,

- Vector<Persistent<NGFloatingObject>>& positioned_floats)

+ Vector<Persistent<NGFloatingObject>>& positioned_floats,

+ NGBreakToken* break_token)

: NGPhysicalFragment(layout_object,

size,

overflow,

@@ -36,7 +37,8 @@ class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragment {

out_of_flow_descendants,

out_of_flow_positions,

unpositioned_floats,

- positioned_floats),

+ positioned_floats,

+ break_token),

node_(node),

item_index_(item_index),

start_offset_(start_offset),