Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc

Issue 2693193002: [LayoutNG] A different approach to multi-col. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_multi_column_layout_algorithm.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_multi_column_layout_algorithm.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
index d59bbb28c41c9dda4cb6a73de8f93fda92b85aa8..f71c9446d592346f7bfaf6a71aa3a05f2d5b4a47 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
@@ -131,7 +131,7 @@ void NGLineBuilder::CreateLineUpToLastBreakOpportunity() {
BidiReorder(&line_item_chunks);
NGFragmentBuilder text_builder(NGPhysicalFragment::kFragmentText,
- inline_box_->GetLayoutObject());
+ inline_box_);
text_builder.SetWritingMode(constraint_space_->WritingMode());
LayoutUnit inline_offset;
for (const auto& line_item_chunk : line_item_chunks) {
« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_multi_column_layout_algorithm.h » ('j') | third_party/WebKit/Source/core/layout/ng/ng_multi_column_layout_algorithm.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698