chrome/browser/extensions/webstore_inline_installer.cc - Issue 2693183002: Allow inline install for user initiated fullscreen mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer.cc

Issue 2693183002: Allow inline install for user initiated fullscreen mode. (Closed)

Patch Set: Updating to use test extension id. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer.cc b/chrome/browser/extensions/webstore_inline_installer.cc

index dbc0499a6a2bd62de824452857205c90914aac1f..ac7bee9d49da38a1849bf52da08028df8719ab67 100644

--- a/chrome/browser/extensions/webstore_inline_installer.cc

+++ b/chrome/browser/extensions/webstore_inline_installer.cc

@@ -184,7 +184,7 @@ bool WebstoreInlineInstaller::CheckInlineInstallPermitted(

}

FullscreenController* controller =

browser->exclusive_access_manager()->fullscreen_controller();

- if (controller->IsFullscreenForBrowser() || controller->IsTabFullscreen()) {

+ if (controller->IsTabFullscreen()) {

*error = kInitiatedFromFullscreenError;

return false;

}

« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_inline_installer_browsertest.cc » ('j') | no next file with comments »