Split backend implementation of EnqueuerListener

Split backend implementation of EnqueuerListener

- into a EnqueuerListenerBase with subclasses ResolutionEnqueuerListener and CodegenEnqueuerListener

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9a1ceea706e56973586fd1f5710b8c264307f135

[Johnni Winther, 2017-02-14 14:28:10]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-17 23:05:08]

lgtm

https://codereview.chromium.org/2693163002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_usage.dart (right):

https://codereview.chromium.org/2693163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_usage.dart:28: bool get
hasInvokeOnSupport;
Let's rename a lot of these properties.

Reading the changes throughout the CL I felt that it was really odd to ask a
`backendUsage` about whether or not something is supported :).  Then I realized
that this is not about something being supported (all of these features are
always supported) but about whether some features are used and therefore we must
reason about them elsewhere.

Here is a proposal for new names:
- hasInvokeOnSupport => isInvokeOnUsed
- hasRuntimeTypeSupport => isRuntimeTypeUsed
- hasIsolateSupport => isIsolateInUse
- hasFunctionApplySupport => isFunctionApplyUsed

I'm OK doing this as a follow up change if you prefer.

[Johnni Winther, 2017-02-20 11:37:43]

https://codereview.chromium.org/2693163002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_usage.dart (right):

https://codereview.chromium.org/2693163002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_usage.dart:28: bool get
hasInvokeOnSupport;
On 2017/02/17 23:05:08, Siggi Cherem (dart-lang) wrote:
> Let's rename a lot of these properties.
> 
> Reading the changes throughout the CL I felt that it was really odd to ask a
> `backendUsage` about whether or not something is supported :).  Then I
realized
> that this is not about something being supported (all of these features are
> always supported) but about whether some features are used and therefore we
must
> reason about them elsewhere.
> 
> Here is a proposal for new names:
> - hasInvokeOnSupport => isInvokeOnUsed
> - hasRuntimeTypeSupport => isRuntimeTypeUsed
> - hasIsolateSupport => isIsolateInUse
> - hasFunctionApplySupport => isFunctionApplyUsed
> 
> I'm OK doing this as a follow up change if you prefer.

Done.

[Johnni Winther, 2017-02-20 11:49:18]

Description was changed from

==========
Split backend implementation of EnqueuerListener

- into a EnqueuerListenerBase with subclasses ResolutionEnqueuerListener and
CodegenEnqueuerListener
==========

to

==========
Split backend implementation of EnqueuerListener

- into a EnqueuerListenerBase with subclasses ResolutionEnqueuerListener and
CodegenEnqueuerListener

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9a1ceea706e56973586fd1f5710b8c264307f135
==========

[Johnni Winther, 2017-02-20 11:49:19]

Committed patchset #3 (id:40001) manually as
9a1ceea706e56973586fd1f5710b8c264307f135 (presubmit successful).