Add GN build file for fontconfig

Add GN build file for fontconfig

R=brettw

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274064

[Ken Rockot(use gerrit already), 2014-05-07 06:32:03]

Could you please take a look at this? Thanks

[brettw, 2014-05-07 17:29:54]

lgtm

[Ken Rockot(use gerrit already), 2014-05-07 18:03:11]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-05-07 18:08:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/269313006/1

[commit-bot: I haz the power, 2014-05-08 00:45:18]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
  mac_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 05:47:34]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-08 05:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 05:53:48]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium

[tfarina, 2014-05-25 23:51:22]

Ken, could you try again?

What was the android failure? The log expired.

Thanks,

https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD.gn
File third_party/fontconfig/BUILD.gn (right):

https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD...
third_party/fontconfig/BUILD.gn:42: "src",
you can remove this, as it is already in fontconfig_config and will be applied
here.

[Ken Rockot(use gerrit already), 2014-05-30 23:50:28]

On 2014/05/25 23:51:22, tfarina wrote:
> Ken, could you try again?
> 
> What was the android failure? The log expired.
> 
> Thanks,
> 
>
https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD.gn
> File third_party/fontconfig/BUILD.gn (right):
> 
>
https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD...
> third_party/fontconfig/BUILD.gn:42: "src",
> you can remove this, as it is already in fontconfig_config and will be applied
> here.

You can probably see now that the android build fails to find f2build.h.
Unfortunately I haven't had much time to look into this since the initial
upload. Nothing jumps out at me. Any ideas?

[Ken Rockot(use gerrit already), 2014-05-30 23:50:46]

On 2014/05/30 23:50:28, Ken Rockot wrote:
> On 2014/05/25 23:51:22, tfarina wrote:
> > Ken, could you try again?
> > 
> > What was the android failure? The log expired.
> > 
> > Thanks,
> > 
> >
>
https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD.gn
> > File third_party/fontconfig/BUILD.gn (right):
> > 
> >
>
https://codereview.chromium.org/269313006/diff/1/third_party/fontconfig/BUILD...
> > third_party/fontconfig/BUILD.gn:42: "src",
> > you can remove this, as it is already in fontconfig_config and will be
applied
> > here.
> 
> You can probably see now that the android build fails to find f2build.h.
> Unfortunately I haven't had much time to look into this since the initial
> upload. Nothing jumps out at me. Any ideas?

ft2build.h* i.e. freetype2

[brettw, 2014-05-30 23:57:35]

https://codereview.chromium.org/269313006/diff/20001/third_party/fontconfig/B...
File third_party/fontconfig/BUILD.gn (right):

https://codereview.chromium.org/269313006/diff/20001/third_party/fontconfig/B...
third_party/fontconfig/BUILD.gn:68: configs += [
"//build/config/linux:freetype2" ]
This won't get hit for Android, and there's no condition in that file. So the
error you're seeing makes sense.

I don't think this file should be used at all when compiling for Android. I'd
put an assert(is_linux) at the top, remove this condition, and add it to the
root build file inside an is_linux check.

[Ken Rockot(use gerrit already), 2014-05-31 00:10:26]

On 2014/05/30 23:57:35, brettw wrote:
>
https://codereview.chromium.org/269313006/diff/20001/third_party/fontconfig/B...
> File third_party/fontconfig/BUILD.gn (right):
> 
>
https://codereview.chromium.org/269313006/diff/20001/third_party/fontconfig/B...
> third_party/fontconfig/BUILD.gn:68: configs += [
> "//build/config/linux:freetype2" ]
> This won't get hit for Android, and there's no condition in that file. So the
> error you're seeing makes sense.
> 
> I don't think this file should be used at all when compiling for Android. I'd
> put an assert(is_linux) at the top, remove this condition, and add it to the
> root build file inside an is_linux check.

Doh. That's simple. I was assuming this should have built on Android. Thanks.

[Ken Rockot(use gerrit already), 2014-05-31 00:10:34]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2014-05-31 00:13:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rockot@chromium.org/269313006/40001

[commit-bot: I haz the power, 2014-05-31 05:16:39]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-31 22:16:33]

Change committed as 274064