Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 269313004: [webcrypto] Fix AES-KW unwrapping for symmetric keys (NSS). (Closed)

Created:
6 years, 7 months ago by eroman
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam, padolph
Visibility:
Public.

Description

[webcrypto] Fix AES-KW unwrapping for symmetric keys (NSS). The unwrapped key did not have the proper flags so it could not be used in other operations (like signing). BUG=370712, 245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269262

Patch Set 1 #

Total comments: 2

Patch Set 2 : LEEEEEEEROY JEEEENKINS!!! #

Patch Set 3 : fix chromeos compile failure. macros be crazy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -11 lines) Patch
M content/child/webcrypto/platform_crypto_nss.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 2 chunks +59 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
eroman
6 years, 7 months ago (2014-05-07 03:34:07 UTC) #1
Ryan Sleevi
lgtm https://codereview.chromium.org/269313004/diff/1/content/child/webcrypto/shared_crypto_unittest.cc File content/child/webcrypto/shared_crypto_unittest.cc (right): https://codereview.chromium.org/269313004/diff/1/content/child/webcrypto/shared_crypto_unittest.cc#newcode2800 content/child/webcrypto/shared_crypto_unittest.cc:2800: // Unwrap a HMAC key using AES-KW, and ...
6 years, 7 months ago (2014-05-08 00:58:43 UTC) #2
eroman
https://codereview.chromium.org/269313004/diff/1/content/child/webcrypto/shared_crypto_unittest.cc File content/child/webcrypto/shared_crypto_unittest.cc (right): https://codereview.chromium.org/269313004/diff/1/content/child/webcrypto/shared_crypto_unittest.cc#newcode2800 content/child/webcrypto/shared_crypto_unittest.cc:2800: // Unwrap a HMAC key using AES-KW, and then ...
6 years, 7 months ago (2014-05-08 01:02:39 UTC) #3
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-08 01:02:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/269313004/20001
6 years, 7 months ago (2014-05-08 01:06:40 UTC) #5
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 7 months ago (2014-05-08 05:01:26 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-08 05:01:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/269313004/20001
6 years, 7 months ago (2014-05-08 05:02:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 06:04:59 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-08 06:16:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium
6 years, 7 months ago (2014-05-08 06:16:57 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 7 months ago (2014-05-08 17:52:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/269313004/40001
6 years, 7 months ago (2014-05-08 18:00:03 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 13:34:47 UTC) #14
Message was sent while issue was closed.
Change committed as 269262

Powered by Google App Engine
This is Rietveld 408576698