Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: extensions/common/manifest_handlers/action_handlers_handler_unittest.cc

Issue 2693053002: cros: Add e2e tests for new_note action handler. Flip feature to stable. (Closed)
Patch Set: Address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/api/_manifest_features.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/manifest_handlers/action_handlers_handler_unittest.cc
diff --git a/extensions/common/manifest_handlers/action_handlers_handler_unittest.cc b/extensions/common/manifest_handlers/action_handlers_handler_unittest.cc
index 055013157398944db0e0652a1f0874b6bc4d3801..c6cf3359d7bd214d175031250adec778651d0902 100644
--- a/extensions/common/manifest_handlers/action_handlers_handler_unittest.cc
+++ b/extensions/common/manifest_handlers/action_handlers_handler_unittest.cc
@@ -48,7 +48,6 @@ class ActionHandlersManifestTest : public ManifestTest {
} // namespace
TEST_F(ActionHandlersManifestTest, InvalidType) {
- extensions::ScopedCurrentChannel channel(version_info::Channel::DEV);
LoadAndExpectError(CreateManifest("32"),
manifest_errors::kInvalidActionHandlersType);
LoadAndExpectError(CreateManifest("[true]"),
@@ -58,7 +57,6 @@ TEST_F(ActionHandlersManifestTest, InvalidType) {
}
TEST_F(ActionHandlersManifestTest, VerifyParse) {
- extensions::ScopedCurrentChannel channel(version_info::Channel::DEV);
scoped_refptr<Extension> none = LoadAndExpectSuccess(CreateManifest("[]"));
EXPECT_EQ(std::set<app_runtime::ActionType>{}, GetActionHandlers(none.get()));
« no previous file with comments | « extensions/common/api/_manifest_features.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698