Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: src/js/typedarray.js

Issue 2693043009: [typedarrays] sort in C++ for undefined comparefn (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/typedarray.js
diff --git a/src/js/typedarray.js b/src/js/typedarray.js
index 7df43779197a8dcb4dabdc1a82bc1212436fff29..65619d2f2a0c11df1ec62626aa5ecb463d53b6ba 100644
--- a/src/js/typedarray.js
+++ b/src/js/typedarray.js
@@ -530,25 +530,6 @@ function TypedArrayReverse() {
return PackedArrayReverse(this, length);
}
-
-function TypedArrayComparefn(x, y) {
- if (x === 0 && x === y) {
- x = 1 / x;
- y = 1 / y;
- }
- if (x < y) {
- return -1;
- } else if (x > y) {
- return 1;
- } else if (NUMBER_IS_NAN(x) && NUMBER_IS_NAN(y)) {
- return NUMBER_IS_NAN(y) ? 0 : 1;
- } else if (NUMBER_IS_NAN(x)) {
- return 1;
- }
- return 0;
-}
-
-
// ES6 draft 05-18-15, section 22.2.3.25
function TypedArraySort(comparefn) {
if (!IS_TYPEDARRAY(this)) throw %make_type_error(kNotTypedArray);
@@ -556,7 +537,7 @@ function TypedArraySort(comparefn) {
var length = %_TypedArrayGetLength(this);
if (IS_UNDEFINED(comparefn)) {
- comparefn = TypedArrayComparefn;
+ return %_TypedArraySortFast(this);
Benedikt Meurer 2017/02/15 05:08:04 Since you call to the runtime anyways, just use %T
}
return InnerArraySort(this, length, comparefn);
« no previous file with comments | « no previous file | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698