[ios clean] Add overflow buttons for ToolsMenu.

ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h

Index: ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h
diff --git a/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h
new file mode 100644
index 0000000000000000000000000000000000000000..7f442a1c617a73f50e397f357f315c71ebb8e07e
--- /dev/null
+++ b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h
@@ -0,0 +1,25 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_OVERFLOW_CONTROLS_STACKVIEW_H_
+#define IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_OVERFLOW_CONTROLS_STACKVIEW_H_
+
+#import <UIKit/UIKit.h>
+
+@class ToolbarButton;
+
+// StackView subclass that contains the Overflow Toolbar Buttons that will be
+// inserted in the first row of ToolMenu in compact widths.
+@interface MenuOverflowControlsStackView : UIStackView

[edchin, 2017/02/15 04:14:50]

I would rather avoid inheritance in this case. 
There is nothing special about MenuOverflowControlsStackView
that warrants the use of inheritance. 
Instead, you can use a category that constructs
a custom stackView. 
UIStackView +(instancetype)cr_menuOverflowControlsStackView. 
In this factory method, you can construct the buttons
and also set their actions. 

[marq (ping after 24h), 2017/02/15 15:06:16]

+1, this is the pattern we've been using so far. Even if we change our minds
later, it's easier if we're consistent.

[sczs, 2017/02/16 00:31:39]

The Buttons visibility needs to be set by the ToolsMenuVCn (Stop/Reload,
Starred/Unstarred), that's why I need a reference to the buttons, and that was
one of the reasons why I was subclassing.
If we want to keep using categories we can create associated objects, or we can
keep this subclass. I had a quick chat with Ed and he thought that this might
enough to keep this as a subclass, WDYT?

[edchin, 2017/02/16 01:21:00]

Agreed. After some more discussion, there's additional functionality in the 
menu overflow controls that requires subclassing. 

+// ToolsMenu ToolbarButton.
+@property(nonatomic, strong) ToolbarButton* toolsMenuButton;
+// Share ToolbarButton.
+@property(nonatomic, strong) ToolbarButton* shareButton;
+// Reload ToolbarButton.
+@property(nonatomic, strong) ToolbarButton* reloadButton;
+// Stop ToolbarButton.
+@property(nonatomic, strong) ToolbarButton* stopButton;
+@end
+
+#endif  // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_MENU_OVERFLOW_CONTROLS_STACKVIEW_H_