Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: ios/clean/chrome/browser/ui/toolbar/BUILD.gn

Issue 2693043002: [ios clean] Add overflow buttons for ToolsMenu. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/toolbar/BUILD.gn
diff --git a/ios/clean/chrome/browser/ui/toolbar/BUILD.gn b/ios/clean/chrome/browser/ui/toolbar/BUILD.gn
index d7aa9070b708df8a9df3417f297eea99717cbb13..99a91e63ba9d2a3ffcd6345c3017f9546c24902a 100644
--- a/ios/clean/chrome/browser/ui/toolbar/BUILD.gn
+++ b/ios/clean/chrome/browser/ui/toolbar/BUILD.gn
@@ -23,22 +23,33 @@ source_set("toolbar") {
source_set("toolbar_ui") {
sources = [
+ "toolbar_view_controller.h",
+ "toolbar_view_controller.mm",
+ ]
+ deps = [
+ ":toolbar_components",
+ "//base",
+ "//ios/clean/chrome/browser/ui/actions",
+ "//ios/clean/chrome/browser/ui/animators",
+ "//ios/clean/chrome/browser/ui/commands",
+ "//ios/clean/chrome/browser/ui/tools",
+ ]
+ libs = [ "UIKit.framework" ]
+ configs += [ "//build/config/compiler:enable_arc" ]
+}
+
+source_set("toolbar_components") {
sczs 2017/02/14 23:54:42 This might or might not be end up being used by To
edchin 2017/02/15 04:14:50 The line between toolbar_ui and toolbar_components
marq (ping after 24h) 2017/02/15 15:06:16 I think the idea is that _components might be used
sczs 2017/02/16 00:31:39 Yes, that is the idea. I guess I could rename this
edchin 2017/02/16 01:21:00 I'm okay with either, with a slight preference for
+ sources = [
"toolbar_button+factory.h",
"toolbar_button+factory.mm",
"toolbar_button.h",
"toolbar_button.mm",
"toolbar_component_options.h",
- "toolbar_view_controller.h",
- "toolbar_view_controller.mm",
]
deps = [
"//base",
"//ios/chrome/app/theme",
"//ios/chrome/browser/ui",
- "//ios/clean/chrome/browser/ui/actions",
- "//ios/clean/chrome/browser/ui/animators",
- "//ios/clean/chrome/browser/ui/commands",
- "//ios/clean/chrome/browser/ui/tools",
]
libs = [ "UIKit.framework" ]
configs += [ "//build/config/compiler:enable_arc" ]

Powered by Google App Engine
This is Rietveld 408576698