Use SwapBuffersWithBounds on Chromecast

cc/output/output_surface_frame.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_OUTPUT_OUTPUT_SURFACE_FRAME_H_
 #define CC_OUTPUT_OUTPUT_SURFACE_FRAME_H_
 
 #include <vector>
 
 #include "base/macros.h"
 #include "cc/base/cc_export.h"
 #include "ui/events/latency_info.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace cc {
 
 // Metadata given to the OutputSurface for it to swap what was drawn and make
 // current frame visible.
 class CC_EXPORT OutputSurfaceFrame {
  public:
   OutputSurfaceFrame();
   OutputSurfaceFrame(OutputSurfaceFrame&& other);
   ~OutputSurfaceFrame();
 
   OutputSurfaceFrame& operator=(OutputSurfaceFrame&& other);
 
   gfx::Size size;
+  // |sub_buffer_rect| = swap rect for PartialSwap if != surface size.
+  // |content_bounds| = content area for SwapWithBounds if non-empty; rectangles
+  // may overlap. If neither is provided, use standard swap. Providing both
+  // |sub_buffer_rect| and |content_bounds| is not supported.

[danakj, 2017/02/16 18:54:19]

I think this is a little misleading. sub_buffer_rect is always provided. But it
may be == surface size. It may also be empty even if not using partial swap but
there's no damage (after doing overlays? when the context supports empty swaps)

That said.. comparing rects are == is a little uh.. oldschool? Maybe this is a
good case for an Optional sub_buffer_rect. That'd make intentions more explicit.
If you agree we could do that as a separate CL for this one to build on.

[halliwell, 2017/02/17 14:08:45]

Yep, looked at this a little closer:
* Optional does sound clearer vs comparing rects.  I'll try putting together a
CL for that first.
* I think this comment is still true to the extent that content_bounds and
sub_buffer_rect can't both be provided.  But yes, there is an additional case -
sub_buffer_rect isn't just for PartialSwap, it can also be empty in the case
where CommitOverlayPlanes is used.  I'll rephrase to clarify in next patchset.

[halliwell, 2017/02/23 18:01:46]

Ok, comment updated, and using Optional now.

   gfx::Rect sub_buffer_rect;
+  std::vector<gfx::Rect> content_bounds;
   std::vector<ui::LatencyInfo> latency_info;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OutputSurfaceFrame);
 };
 
 }  // namespace cc
 
 #endif  // CC_OUTPUT_OUTPUT_SURFACE_FRAME_H_