arc: Add cryptohome_id to EmitArcBooted.

chromeos/dbus/fake_session_manager_client.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/fake_session_manager_client.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
@@ skipping 171 matching lines @@
       FROM_HERE, base::Bind(callback, arc_available_));
 }
 
 void FakeSessionManagerClient::SetArcCpuRestriction(
     login_manager::ContainerCpuRestrictionState restriction_state,
     const ArcCallback& callback) {
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(callback, arc_available_));
 }
 
-void FakeSessionManagerClient::EmitArcBooted() {}
+void FakeSessionManagerClient::EmitArcBooted(
+    const cryptohome::Identification& cryptohome_id,
+    const ArcCallback& callback) {
+  if (!callback.is_null()) {

[Luis Héctor Chávez, 2017/02/15 19:02:11]

use guard clause pattern:

if (callback.is_null())
  return;
// rest.

then again, why would |callback| be null? Why not DCHECK(!callback.is_null()); ?

[xzhou, 2017/02/16 18:34:50]

I am not sure why we check it here. I see RemoveArcData checks it. Is that
related the life cycle of ArcSessionManager?

[Yusuke Sato, 2017/02/16 18:42:57]

RemoveArcData's check seems just redundant. I don't think you need it here.

[xzhou, 2017/02/16 20:17:31]

Done.

+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::Bind(callback, arc_available_));
+  }
+}
 
 void FakeSessionManagerClient::GetArcStartTime(
     const GetArcStartTimeCallback& callback) {
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(callback, arc_available_, base::TimeTicks::Now()));
 }
 
 void FakeSessionManagerClient::RemoveArcData(
     const cryptohome::Identification& cryptohome_id,
     const ArcCallback& callback) {
@@ skipping 38 matching lines @@
     const std::string& policy_blob) {
   device_local_account_policy_[account_id] = policy_blob;
 }
 
 void FakeSessionManagerClient::OnPropertyChangeComplete(bool success) {
   for (auto& observer : observers_)
     observer.PropertyChangeComplete(success);
 }
 
 }  // namespace chromeos