Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Issue 2693013005: Updated tab history classes to use NavigationItemLists. (Closed)
Patch Set: update DEPS, include url_formatter in BUILD.gn Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/toolbar/web_toolbar_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
diff --git a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
index 498ce10373c82bd852a07cccaedd1af53cb732c8..ee215e354a909ac338f9adc1e4f8f45749a95814 100644
--- a/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
+++ b/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
@@ -805,7 +805,7 @@ - (UIImage*)snapshotWithWidth:(CGFloat)width {
}
- (void)showTabHistoryPopupInView:(UIView*)view
- withSessionEntries:(NSArray*)sessionEntries
+ withItems:(const web::NavigationItemList&)items
forBackHistory:(BOOL)isBackHistory {
if (_tabHistoryPopupController)
return;
@@ -826,9 +826,15 @@ - (void)showTabHistoryPopupInView:(UIView*)view
_tabHistoryPopupController.reset([[TabHistoryPopupController alloc]
initWithOrigin:convertedOrigin
parentView:view
- entries:sessionEntries]);
+ items:items]);
[_tabHistoryPopupController setDelegate:self];
+ // Fade in the popup and notify observers.
+ CGRect containerFrame = [[_tabHistoryPopupController popupContainer] frame];
+ CGPoint destination = CGPointMake(CGRectGetLeadingEdge(containerFrame),
+ CGRectGetMinY(containerFrame));
+ [_tabHistoryPopupController fadeInPopupFromSource:convertedOrigin
+ toDestination:destination];
[[NSNotificationCenter defaultCenter]
postNotificationName:kTabHistoryPopupWillShowNotification
object:nil];
« no previous file with comments | « ios/chrome/browser/ui/toolbar/web_toolbar_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698