Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Side by Side Diff: ios/chrome/browser/ui/history/tab_history_view_controller.h

Issue 2693013005: Updated tab history classes to use NavigationItemLists. (Closed)
Patch Set: move TabHistoryPopupController ivar underscore to prefix, pass items by reference to toolbar Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_ 5 #ifndef IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_
6 #define IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_ 6 #define IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_
7 7
8 #import <UIKit/UIKit.h> 8 #import <UIKit/UIKit.h>
9 9
10 #include "ios/web/public/navigation_item_list.h"
11
10 // View controller for displaying a list of CRWSessionEntry objects in a table. 12 // View controller for displaying a list of CRWSessionEntry objects in a table.
11 @interface TabHistoryViewController : UICollectionViewController 13 @interface TabHistoryViewController : UICollectionViewController
12 14
13 // TODO(crbug.com/546355): Convert this class to use an array of 15 // Initializer that takes a NavigationItemList.
14 // NavigationEntries. 16 - (instancetype)initWithItems:(const web::NavigationItemList&)items;
Eugene But (OOO till 7-30) 2017/02/14 23:08:08 nit: NS_DESIGNATED_INITIALIZER ?
kkhorimoto 2017/02/14 23:23:51 Done.
15 @property(nonatomic, strong) NSArray* sessionEntries;
16 17
17 // Returns the optimal height needed to display the session entries. 18 // Returns the optimal height needed to display the session entries.
18 // The height returned is usually less than the |suggestedHeight| unless 19 // The height returned is usually less than the |suggestedHeight| unless
19 // the last row of the table puts the height just over the |suggestedHeight|. 20 // the last row of the table puts the height just over the |suggestedHeight|.
20 // If the session entries table is taller than the |suggestedHeight| by at least 21 // If the session entries table is taller than the |suggestedHeight| by at least
21 // one row, the last visible session entry will be shown partially so the user 22 // one row, the last visible session entry will be shown partially so the user
22 // can tell that the table is scrollable. 23 // can tell that the table is scrollable.
23 - (CGFloat)optimalHeight:(CGFloat)suggestedHeight; 24 - (CGFloat)optimalHeight:(CGFloat)suggestedHeight;
24 25
25 @end 26 @end
26 27
27 #endif // IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_ 28 #endif // IOS_CHROME_BROWSER_UI_HISTORY_TAB_HISTORY_VIEW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698