Use relative path for scripts loaded in content WebUI's

Use relative path for scripts loaded in content WebUI's

Specifying relative path works exactly the same as specifying absolute
path, as long as the script is declared using
WebUIDataSource::AddResourcePath (which it is in case of changed
WebUIs). So there is no behavioral change in case of Chromium. The
reason for this change is it makes the live of embedders of content
easier when embedder is loading the WebUI from a scheme that is not
chrome: (it is opera: for us). It allows us to save on on adding
security policy overrides for each content WebUI.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230401

[jiayl, 2013-10-15 17:49:43]

On 2013/10/10 21:36:55, Rafał Chłodnicki wrote:

These pages have other absolute script paths like chrome://resources/js/*. How
could it work if you change only one of them?

[Rafał Chłodnicki, 2013-10-15 17:55:05]

On 2013/10/15 17:49:43, jiayl wrote:
> On 2013/10/10 21:36:55, Rafał Chłodnicki wrote:
> 
> These pages have other absolute script paths like chrome://resources/js/*. How
> could it work if you change only one of them?

chrome://resources works for us because we have added an exception to allow
loading chrome://resources in those and the rest of the content UIs. We use
WebSecurityPolicy::addOriginAccessWhitelistEntry for that. But we want to
minimize those if possible.

[jiayl, 2013-10-15 17:59:23]

On 2013/10/15 17:55:05, Rafał Chłodnicki wrote:
> On 2013/10/15 17:49:43, jiayl wrote:
> > On 2013/10/10 21:36:55, Rafał Chłodnicki wrote:
> > 
> > These pages have other absolute script paths like chrome://resources/js/*.
How
> > could it work if you change only one of them?
> 
> chrome://resources works for us because we have added an exception to allow
> loading chrome://resources in those and the rest of the content UIs. We use
> WebSecurityPolicy::addOriginAccessWhitelistEntry for that. But we want to
> minimize those if possible.

OK. LGTM, but I'm an owner of the media directory. Added Ami instead.

[Ami GONE FROM CHROMIUM, 2013-10-15 18:03:59]

media LGTM assuming it still works in chrome ;)

[commit-bot: I haz the power, 2013-10-21 21:26:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/26930002/1

[Rafał Chłodnicki, 2013-10-21 21:33:25]

On 2013/10/21 21:26:46, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/rchlodnicki%40opera.com/26930002/1

Needs review from the owner - nduca?

[commit-bot: I haz the power, 2013-10-21 21:46:56]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[nduca, 2013-10-23 07:00:08]

a very belated lgtm

[commit-bot: I haz the power, 2013-10-23 08:31:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/26930002/1

[commit-bot: I haz the power, 2013-10-23 13:49:13]

Change committed as 230401