Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 26930002: Use relative path for scripts loaded in content WebUI's (Closed)

Created:
7 years, 2 months ago by Rafał Chłodnicki
Modified:
7 years, 2 months ago
CC:
chromium-reviews, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use relative path for scripts loaded in content WebUI's Specifying relative path works exactly the same as specifying absolute path, as long as the script is declared using WebUIDataSource::AddResourcePath (which it is in case of changed WebUIs). So there is no behavioral change in case of Chromium. The reason for this change is it makes the live of embedders of content easier when embedder is loading the WebUI from a scheme that is not chrome: (it is opera: for us). It allows us to save on on adding security policy overrides for each content WebUI. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/resources/gpu/gpu_internals.html View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resources/media/webrtc_internals.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Rafał Chłodnicki
7 years, 2 months ago (2013-10-10 21:36:55 UTC) #1
jiayl
On 2013/10/10 21:36:55, Rafał Chłodnicki wrote: These pages have other absolute script paths like chrome://resources/js/*. ...
7 years, 2 months ago (2013-10-15 17:49:43 UTC) #2
Rafał Chłodnicki
On 2013/10/15 17:49:43, jiayl wrote: > On 2013/10/10 21:36:55, Rafał Chłodnicki wrote: > > These ...
7 years, 2 months ago (2013-10-15 17:55:05 UTC) #3
jiayl
On 2013/10/15 17:55:05, Rafał Chłodnicki wrote: > On 2013/10/15 17:49:43, jiayl wrote: > > On ...
7 years, 2 months ago (2013-10-15 17:59:23 UTC) #4
Ami GONE FROM CHROMIUM
media LGTM assuming it still works in chrome ;)
7 years, 2 months ago (2013-10-15 18:03:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/26930002/1
7 years, 2 months ago (2013-10-21 21:26:46 UTC) #6
Rafał Chłodnicki
On 2013/10/21 21:26:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 2 months ago (2013-10-21 21:33:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=31650
7 years, 2 months ago (2013-10-21 21:46:56 UTC) #8
nduca
a very belated lgtm
7 years, 2 months ago (2013-10-23 07:00:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rchlodnicki@opera.com/26930002/1
7 years, 2 months ago (2013-10-23 08:31:07 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 13:49:13 UTC) #11
Message was sent while issue was closed.
Change committed as 230401

Powered by Google App Engine
This is Rietveld 408576698