Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: services/device/device_service.cc

Issue 2692993006: Port device_sensors to be hosted in Device Service (Closed)
Patch Set: code rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/device/device_service.cc
diff --git a/services/device/device_service.cc b/services/device/device_service.cc
index 7a225c43c71cd0408c5566605184f2d8626a7bfa..e7c7709b3a65457e6a9da49c6ce0b045b02ebfa0 100644
--- a/services/device/device_service.cc
+++ b/services/device/device_service.cc
@@ -8,6 +8,7 @@
#include "base/memory/ptr_util.h"
#include "base/memory/weak_ptr.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "device/sensors/device_sensor_host.h"
#include "services/device/power_monitor/power_monitor_message_broadcaster.h"
#include "services/device/time_zone_monitor/time_zone_monitor.h"
#include "services/service_manager/public/cpp/connection.h"
@@ -20,7 +21,8 @@
namespace device {
std::unique_ptr<service_manager::Service> CreateDeviceService(
- scoped_refptr<base::SingleThreadTaskRunner> file_task_runner) {
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner) {
#if defined(OS_ANDROID)
if (!EnsureJniRegistered()) {
DLOG(ERROR) << "Failed to register JNI for Device Service";
@@ -28,12 +30,15 @@ std::unique_ptr<service_manager::Service> CreateDeviceService(
}
#endif
- return base::MakeUnique<DeviceService>(std::move(file_task_runner));
+ return base::MakeUnique<DeviceService>(std::move(file_task_runner),
+ std::move(io_task_runner));
}
DeviceService::DeviceService(
- scoped_refptr<base::SingleThreadTaskRunner> file_task_runner)
- : file_task_runner_(std::move(file_task_runner)) {}
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
+ : file_task_runner_(std::move(file_task_runner)),
+ io_task_runner_(std::move(io_task_runner)) {}
DeviceService::~DeviceService() {}
@@ -41,12 +46,82 @@ void DeviceService::OnStart() {}
bool DeviceService::OnConnect(const service_manager::ServiceInfo& remote_info,
service_manager::InterfaceRegistry* registry) {
+ registry->AddInterface<mojom::LightSensor>(this);
+ registry->AddInterface<mojom::MotionSensor>(this);
+ registry->AddInterface<mojom::OrientationSensor>(this);
+ registry->AddInterface<mojom::OrientationAbsoluteSensor>(this);
registry->AddInterface<mojom::PowerMonitor>(this);
registry->AddInterface<mojom::TimeZoneMonitor>(this);
return true;
}
void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::LightSensorRequest request) {
+#if defined(OS_ANDROID)
+ // On Android the device sensors implementations need to run on the UI thread
+ // to communicate to Java.
+ DeviceLightHost::Create(std::move(request));
+#else
+ // On platforms other than Android the device sensors implementations run on
+ // the IO thread.
+ if (io_task_runner_) {
+ io_task_runner_->PostTask(FROM_HERE, base::Bind(&DeviceLightHost::Create,
+ base::Passed(&request)));
+ }
+#endif // defined(OS_ANDROID)
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::MotionSensorRequest request) {
+#if defined(OS_ANDROID)
+ // On Android the device sensors implementations need to run on the UI thread
+ // to communicate to Java.
+ DeviceMotionHost::Create(std::move(request));
+#else
+ // On platforms other than Android the device sensors implementations run on
+ // the IO thread.
+ if (io_task_runner_) {
+ io_task_runner_->PostTask(FROM_HERE, base::Bind(&DeviceMotionHost::Create,
+ base::Passed(&request)));
+ }
+#endif // defined(OS_ANDROID)
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::OrientationSensorRequest request) {
+#if defined(OS_ANDROID)
+ // On Android the device sensors implementations need to run on the UI thread
+ // to communicate to Java.
+ DeviceOrientationHost::Create(std::move(request));
+#else
+ // On platforms other than Android the device sensors implementations run on
+ // the IO thread.
+ if (io_task_runner_) {
+ io_task_runner_->PostTask(
+ FROM_HERE,
+ base::Bind(&DeviceOrientationHost::Create, base::Passed(&request)));
+ }
+#endif // defined(OS_ANDROID)
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
+ mojom::OrientationAbsoluteSensorRequest request) {
+#if defined(OS_ANDROID)
+ // On Android the device sensors implementations need to run on the UI thread
+ // to communicate to Java.
+ DeviceOrientationAbsoluteHost::Create(std::move(request));
+#else
+ // On platforms other than Android the device sensors implementations run on
+ // the IO thread.
+ if (io_task_runner_) {
+ io_task_runner_->PostTask(FROM_HERE,
+ base::Bind(&DeviceOrientationAbsoluteHost::Create,
+ base::Passed(&request)));
+ }
+#endif // defined(OS_ANDROID)
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
mojom::PowerMonitorRequest request) {
PowerMonitorMessageBroadcaster::Create(std::move(request));
}

Powered by Google App Engine
This is Rietveld 408576698