Port device_sensors to be hosted in Device Service

content/renderer/device_sensors/device_sensor_event_pump.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_DEVICE_SENSORS_DEVICE_SENSOR_EVENT_PUMP_H_
 #define CONTENT_RENDERER_DEVICE_SENSORS_DEVICE_SENSOR_EVENT_PUMP_H_
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/shared_memory.h"
 #include "base/time/time.h"
 #include "base/timer/timer.h"
+#include "content/public/common/service_manager_connection.h"
 #include "content/public/renderer/platform_event_observer.h"
 #include "content/renderer/render_thread_impl.h"
 #include "mojo/public/cpp/system/platform_handle.h"
-#include "services/service_manager/public/cpp/interface_provider.h"
+#include "services/device/public/interfaces/constants.mojom.h"
+#include "services/service_manager/public/cpp/connector.h"
 
 namespace content {
 
 template <typename Base, typename MojoInterface>
 class CONTENT_EXPORT DeviceSensorMojoClientMixin : public Base {
  public:
   template <typename... Args>
   explicit DeviceSensorMojoClientMixin(Args&&... args)
       : Base(std::forward<Args>(args)...) {
-    mojo::InterfaceRequest<MojoInterface> request(&mojo_interface_);

[blundell, 2017/02/22 16:30:24]

The problem is here. You're now not binding |mojo_interface_| if lines 38-41
aren't executed (which they aren't in layout tests). However, |mojo_interface_|
is later being dereferenced, which causes the renderer to crash. An easy fix is
to just preserve the behavior of binding |mojo_interface_| unconditionally, then
either sending the other end of the pipe to the impl or not.

 
     // When running layout tests, those observers should not listen to the
     // actual hardware changes. In order to make that happen, don't connect
     // the other end of the mojo pipe to anything.
     //
     // TODO(sammc): Remove this when JS layout test support for shared buffers
     // is ready and the layout tests are converted to use that for mocking.
     if (RenderThreadImpl::current() &&
         !RenderThreadImpl::current()->layout_test_mode()) {
-      RenderThread::Get()->GetRemoteInterfaces()->GetInterface(
-          std::move(request));
+      RenderThreadImpl::current()
+          ->GetServiceManagerConnection()
+          ->GetConnector()
+          ->BindInterface(device::mojom::kServiceName, &mojo_interface_);
     }
   }
 
   void SendStartMessage() override {
     mojo_interface_->StartPolling(
         base::Bind(&DeviceSensorMojoClientMixin<Base, MojoInterface>::DidStart,
                    base::Unretained(this)));
   }
   void SendStopMessage() override { mojo_interface_->StopPolling(); }
 
@@ skipping 92 matching lines @@
   int pump_delay_microseconds_;
   PumpState state_;
   base::RepeatingTimer timer_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceSensorEventPump);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_DEVICE_SENSORS_DEVICE_SENSOR_EVENT_PUMP_H_