Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/AdvancedSearchView.js

Issue 2692923013: DevTools: do not search in anonymous scripts unless specifically asked for. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Sources.AdvancedSearchView = class extends UI.VBox { 7 Sources.AdvancedSearchView = class extends UI.VBox {
8 constructor() { 8 constructor() {
9 super(true); 9 super(true);
10 this.setMinimumSize(0, 40); 10 this.setMinimumSize(0, 40);
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 if (searchId !== this._searchId || !this._progressIndicator) 147 if (searchId !== this._searchId || !this._progressIndicator)
148 return; 148 return;
149 if (this._progressIndicator && this._progressIndicator.isCanceled()) { 149 if (this._progressIndicator && this._progressIndicator.isCanceled()) {
150 this._onIndexingFinished(); 150 this._onIndexingFinished();
151 return; 151 return;
152 } 152 }
153 this._addSearchResult(searchResult); 153 this._addSearchResult(searchResult);
154 if (!searchResult.searchMatches.length) 154 if (!searchResult.searchMatches.length)
155 return; 155 return;
156 if (!this._searchResultsPane) 156 if (!this._searchResultsPane)
157 this._searchResultsPane = this._searchScope.createSearchResultsPane(this._ searchConfig); 157 this._searchResultsPane = new Sources.FileBasedSearchResultsPane(this._sea rchConfig);
158 this._resetResults(); 158 this._resetResults();
159 this._searchResultsElement.appendChild(this._searchResultsPane.element); 159 this._searchResultsElement.appendChild(this._searchResultsPane.element);
160 this._searchResultsPane.addSearchResult(searchResult); 160 this._searchResultsPane.addSearchResult(searchResult);
161 } 161 }
162 162
163 /** 163 /**
164 * @param {number} searchId 164 * @param {number} searchId
165 * @param {boolean} finished 165 * @param {boolean} finished
166 */ 166 */
167 _onSearchFinished(searchId, finished) { 167 _onSearchFinished(searchId, finished) {
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
428 * @param {function(!Sources.FileBasedSearchResult)} searchResultCallback 428 * @param {function(!Sources.FileBasedSearchResult)} searchResultCallback
429 * @param {function(boolean)} searchFinishedCallback 429 * @param {function(boolean)} searchFinishedCallback
430 */ 430 */
431 performSearch(searchConfig, progress, searchResultCallback, searchFinishedCall back) {}, 431 performSearch(searchConfig, progress, searchResultCallback, searchFinishedCall back) {},
432 432
433 /** 433 /**
434 * @param {!Common.Progress} progress 434 * @param {!Common.Progress} progress
435 */ 435 */
436 performIndexing(progress) {}, 436 performIndexing(progress) {},
437 437
438 stopSearch() {}, 438 stopSearch() {}
439
440 /**
441 * @param {!Workspace.ProjectSearchConfig} searchConfig
442 * @return {!Sources.SearchResultsPane}
443 */
444 createSearchResultsPane(searchConfig) {}
445 }; 439 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698