DevTools: do not search in anonymous scripts unless specifically asked for.

third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  * 1. Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *
@@ skipping 56 matching lines @@
       var project = projects[i];
       var projectProgress = compositeProgress.createSubProgress(project.uiSourceCodes().length);
       project.indexContent(projectProgress);
     }
   }
 
   /**
    * @return {!Array.<!Workspace.Project>}
    */
   _projects() {
-    /**
-     * @param {!Workspace.Project} project
-     * @return {boolean}
-     */
-    function filterOutServiceProjects(project) {
-      return project.type() !== Workspace.projectTypes.Service;
-    }
+    var searchInDynamicScriptsAndExtensions = Common.moduleSetting('searchInDynamicScriptsAndExtensions').get();
 
-    /**
-     * @param {!Workspace.Project} project
-     * @return {boolean}
-     */
-    function filterOutContentScriptsIfNeeded(project) {
-      return Common.moduleSetting('searchInContentScripts').get() ||
-          project.type() !== Workspace.projectTypes.ContentScripts;
-    }
-
-    return Workspace.workspace.projects().filter(filterOutServiceProjects).filter(filterOutContentScriptsIfNeeded);
+    return Workspace.workspace.projects()
+        .filter(project => project.type() !== Workspace.projectTypes.Service)

[dgozman, 2017/02/22 20:17:06]

I personally don't like chaining multiple calls doing the same thing. Can we
have a single filter function which would check all the conditions instead?

[lushnikov, 2017/02/22 21:22:37]

Done.

+        .filter(project => searchInDynamicScriptsAndExtensions || !project.isServiceProject())
+        .filter(
+            project => searchInDynamicScriptsAndExtensions || project.type() !== Workspace.projectTypes.ContentScripts);
   }
 
   /**
    * @override
    * @param {!Workspace.ProjectSearchConfig} searchConfig
    * @param {!Common.Progress} progress
    * @param {function(!Sources.FileBasedSearchResult)} searchResultCallback
    * @param {function(boolean)} searchFinishedCallback
    */
   performSearch(searchConfig, progress, searchResultCallback, searchFinishedCallback) {
@@ skipping 171 matching lines @@
       scheduleSearchInNextFileOrFinish.call(this);
     }
   }
 
   /**
    * @override
    */
   stopSearch() {
     ++this._searchId;
   }
-
-  /**
-   * @override
-   * @param {!Workspace.ProjectSearchConfig} searchConfig
-   * @return {!Sources.FileBasedSearchResultsPane}
-   */
-  createSearchResultsPane(searchConfig) {
-    return new Sources.FileBasedSearchResultsPane(searchConfig);
-  }
 };