chrome/browser/ui/views/payments/payment_request_sheet_controller.h - Issue 2692923011: [Payments] Adjust the UI fit the mocks better

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.h

Issue 2692923011: [Payments] Adjust the UI fit the mocks better (Closed)

Patch Set: Initial Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/payments/editor_view_controller.cc ('k') | chrome/browser/ui/views/payments/payment_request_sheet_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.h

diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h

index a3d2497752e9139cbd9d1b7edaffecd3063bcba9..d7c73e7f60f20b8224ca6e4684f44c2af80d1eeb 100644

--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.h

+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.h

@@ -33,6 +33,9 @@ class PaymentRequestSheetController : public views::VectorIconButtonDelegate {

~PaymentRequestSheetController() override {}

virtual std::unique_ptr<views::View> CreateView() = 0;

+ // A leading view to complement the button(s). See CreateFooterView for how

+ // this is used and what insets are already applied.

+ virtual std::unique_ptr<views::View> CreateLeadingFooterView();

please use gerrit instead 2017/02/18 15:06:14 Would it be possible to add ASCII art similar to C

Mathieu 2017/02/18 15:41:02 Thanks, I've added it in editor_view_controller.cc

// The PaymentRequest object associated with this instance of the dialog.

// Caller should not take ownership of the result.