Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5268)

Unified Diff: chrome/browser/printing/print_job.cc

Issue 2692923006: Add job id to JobEventDetails. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job.cc
diff --git a/chrome/browser/printing/print_job.cc b/chrome/browser/printing/print_job.cc
index 5f616b42d859b960ddc771631383528806905cb1..fedecc30f6f29b49ce65b03fea221b2cd22632f6 100644
--- a/chrome/browser/printing/print_job.cc
+++ b/chrome/browser/printing/print_job.cc
@@ -137,8 +137,8 @@ void PrintJob::StartPrinting() {
is_job_pending_ = true;
// Tell everyone!
- scoped_refptr<JobEventDetails> details(
- new JobEventDetails(JobEventDetails::NEW_DOC, document_.get(), nullptr));
+ scoped_refptr<JobEventDetails> details(new JobEventDetails(
+ JobEventDetails::NEW_DOC, 0, document_.get(), nullptr));
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_PRINT_JOB_EVENT,
content::Source<PrintJob>(this),
@@ -183,7 +183,7 @@ void PrintJob::Cancel() {
}
// Make sure a Cancel() is broadcast.
scoped_refptr<JobEventDetails> details(
- new JobEventDetails(JobEventDetails::FAILED, nullptr, nullptr));
+ new JobEventDetails(JobEventDetails::FAILED, 0, nullptr, nullptr));
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_PRINT_JOB_EVENT,
content::Source<PrintJob>(this),
@@ -408,8 +408,8 @@ void PrintJob::OnDocumentDone() {
// Stop the worker thread.
Stop();
- scoped_refptr<JobEventDetails> details(
- new JobEventDetails(JobEventDetails::JOB_DONE, document_.get(), nullptr));
+ scoped_refptr<JobEventDetails> details(new JobEventDetails(
+ JobEventDetails::JOB_DONE, 0, document_.get(), nullptr));
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_PRINT_JOB_EVENT,
content::Source<PrintJob>(this),
@@ -466,12 +466,10 @@ void PrintJob::Quit() {
// Takes settings_ ownership and will be deleted in the receiving thread.
JobEventDetails::JobEventDetails(Type type,
+ int job_id,
PrintedDocument* document,
PrintedPage* page)
- : document_(document),
- page_(page),
- type_(type) {
-}
+ : document_(document), page_(page), type_(type), job_id_(job_id) {}
JobEventDetails::~JobEventDetails() {
}
« no previous file with comments | « chrome/browser/printing/print_job.h ('k') | chrome/browser/printing/print_job_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698