Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: cleanup and tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
index 89f8b67ed7531bd47f8619d88d91b4e59aeef7df..106a1c46a46a3ca02047ce089a728d38ee00c624 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp
@@ -532,7 +532,10 @@ void MediaControls::refreshCastButtonVisibilityWithoutUpdate() {
// non-cast changes (e.g., resize) occur. If the panel button
// is shown, however, compute...() will take control of the
// overlay cast button if it needs to hide it from the panel.
- m_overlayCastButton->tryShowOverlay();
+ if (!document().settings() ||
+ !document().settings()->getMediaControlsEnabled()) {
+ m_overlayCastButton->tryShowOverlay();
+ }
m_castButton->setIsWanted(false);
} else if (mediaElement().shouldShowControls()) {
m_overlayCastButton->setIsWanted(false);

Powered by Google App Engine
This is Rietveld 408576698