Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 9e954d813c5dec1a290def689ce1f51c1f983c6a..b15f29c38e5d5c5ccc6c0d6baba13ad58215fd7e 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4246,6 +4246,10 @@ bool WebContentsImpl::HideDownloadUI() const {
return is_overlay_content_;
}
+bool WebContentsImpl::HasPersistentVideo() const {
+ return has_persistent_video_;
+}
+
bool WebContentsImpl::IsFocusedElementEditable() {
RenderFrameHostImpl* frame = GetFocusedFrame();
return frame && frame->has_focused_editable_element();
@@ -5272,6 +5276,14 @@ void WebContentsImpl::DecrementBluetoothConnectedDeviceCount() {
}
}
+void WebContentsImpl::SetHasPersistentVideo(bool value) {
+ if (has_persistent_video_ == value)
+ return;
+
+ has_persistent_video_ = value;
+ NotifyPreferencesChanged();
+}
+
#if defined(OS_ANDROID)
void WebContentsImpl::NotifyFindMatchRectsReply(
int version,
@@ -5336,19 +5348,7 @@ void WebContentsImpl::UpdateWebContentsVisibility(bool visible) {
}
void WebContentsImpl::UpdateOverridingUserAgent() {
- std::set<RenderViewHost*> render_view_host_set;
- for (FrameTreeNode* node : frame_tree_.Nodes()) {
- RenderWidgetHost* render_widget_host =
- node->current_frame_host()->GetRenderWidgetHost();
- if (!render_widget_host)
- continue;
- RenderViewHost* render_view_host = RenderViewHost::From(render_widget_host);
- if (!render_view_host)
- continue;
- render_view_host_set.insert(render_view_host);
- }
- for (RenderViewHost* render_view_host : render_view_host_set)
- render_view_host->OnWebkitPreferencesChanged();
+ NotifyPreferencesChanged();
}
void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
@@ -5409,4 +5409,20 @@ void WebContentsImpl::ShowInsecureLocalhostWarningIfNeeded() {
" releasing your website to the public."));
}
+void WebContentsImpl::NotifyPreferencesChanged() {
+ std::set<RenderViewHost*> render_view_host_set;
+ for (FrameTreeNode* node : frame_tree_.Nodes()) {
+ RenderWidgetHost* render_widget_host =
+ node->current_frame_host()->GetRenderWidgetHost();
+ if (!render_widget_host)
+ continue;
+ RenderViewHost* render_view_host = RenderViewHost::From(render_widget_host);
+ if (!render_view_host)
+ continue;
+ render_view_host_set.insert(render_view_host);
+ }
+ for (RenderViewHost* render_view_host : render_view_host_set)
+ render_view_host->OnWebkitPreferencesChanged();
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698