Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: third_party/WebKit/Source/core/frame/Settings.json5

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)
Patch Set: cleanup and tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 { 1 {
2 // Defines properties which are available on the Settings object. 2 // Defines properties which are available on the Settings object.
3 // 3 //
4 // Please think carefully before adding a new Setting. Some questions to 4 // Please think carefully before adding a new Setting. Some questions to
5 // consider are: 5 // consider are:
6 // - Should this be a RuntimeEnabledFeature instead? Settings are for things 6 // - Should this be a RuntimeEnabledFeature instead? Settings are for things
7 // which we support either values of at runtime. Features are set at render er 7 // which we support either values of at runtime. Features are set at render er
8 // process startup and are never changed. Features also tend to be set to a 8 // process startup and are never changed. Features also tend to be set to a
9 // value based on the platform or the stability of the code in question, whe re 9 // value based on the platform or the stability of the code in question, whe re
10 // as settings both codepaths need to be stable. 10 // as settings both codepaths need to be stable.
(...skipping 894 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 name: "fetchImagePlaceholders", 905 name: "fetchImagePlaceholders",
906 initial: false, 906 initial: false,
907 }, 907 },
908 908
909 // Whether the frame is a presentation receiver and should expose 909 // Whether the frame is a presentation receiver and should expose
910 // `navigator.presentation.receiver`. 910 // `navigator.presentation.receiver`.
911 { 911 {
912 name: "presentationReceiver", 912 name: "presentationReceiver",
913 initial: false, 913 initial: false,
914 }, 914 },
915
916 // Whether Blink should show media controls when `controls` attribute is use d.
917 {
918 name: "mediaControlsEnabled",
919 initial: true,
920 invalidate: "MediaControls",
921 },
915 ], 922 ],
916 } 923 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698