content/public/common/common_param_traits_macros.h - Issue 2692903002: Don't show media controls when there is a persistent video.

Side by Side Diff: content/public/common/common_param_traits_macros.h

Issue 2692903002: Don't show media controls when there is a persistent video. (Closed)

Patch Set: cleanup and tests Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/web_contents/web_contents_impl.h ('K') | « content/public/android/java/src/org/chromium/content_public/browser/WebContents.java ('k') | content/public/common/web_preferences.h » ('j') | content/public/common/web_preferences.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Singly or Multiply-included shared traits file depending on circumstances.	5 // Singly or Multiply-included shared traits file depending on circumstances.

6 // This allows the use of IPC serialization macros in more than one IPC message	6 // This allows the use of IPC serialization macros in more than one IPC message

7 // file.	7 // file.

8 #ifndef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_	8 #ifndef CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_

9 #define CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_	9 #define CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_

10	10

(...skipping 222 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
233 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_merge_content_quirk)	233 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_merge_content_quirk)

234 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_non_user_scalable_quirk)	234 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_non_user_scalable_quirk)

235 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_zero_values_quirk)	235 IPC_STRUCT_TRAITS_MEMBER(viewport_meta_zero_values_quirk)

236 IPC_STRUCT_TRAITS_MEMBER(clobber_user_agent_initial_scale_quirk)	236 IPC_STRUCT_TRAITS_MEMBER(clobber_user_agent_initial_scale_quirk)

237 IPC_STRUCT_TRAITS_MEMBER(ignore_main_frame_overflow_hidden_quirk)	237 IPC_STRUCT_TRAITS_MEMBER(ignore_main_frame_overflow_hidden_quirk)

238 IPC_STRUCT_TRAITS_MEMBER(report_screen_size_in_physical_pixels_quirk)	238 IPC_STRUCT_TRAITS_MEMBER(report_screen_size_in_physical_pixels_quirk)

239 IPC_STRUCT_TRAITS_MEMBER(resue_global_for_unowned_main_frame)	239 IPC_STRUCT_TRAITS_MEMBER(resue_global_for_unowned_main_frame)

240 IPC_STRUCT_TRAITS_MEMBER(progress_bar_completion)	240 IPC_STRUCT_TRAITS_MEMBER(progress_bar_completion)

241 IPC_STRUCT_TRAITS_MEMBER(spellcheck_enabled_by_default)	241 IPC_STRUCT_TRAITS_MEMBER(spellcheck_enabled_by_default)

242 IPC_STRUCT_TRAITS_MEMBER(video_fullscreen_orientation_lock_enabled)	242 IPC_STRUCT_TRAITS_MEMBER(video_fullscreen_orientation_lock_enabled)

	243 IPC_STRUCT_TRAITS_MEMBER(media_controls_enabled)
	nasko 2017/02/13 22:28:42 Please order this the same way it is inside the st Please order this the same way it is inside the struct in the header file. In this case right after presentation_receiver. mlamouri (slow - plz ping) 2017/02/14 11:19:46 Oups. I first wrote the implementation as Android Show quoted text On 2017/02/13 at 22:28:42, nasko wrote: > Please order this the same way it is inside the struct in the header file. In this case right after presentation_receiver. Oups. I first wrote the implementation as Android specific then changed. Done.
243 #else // defined(OS_ANDROID)	244 #else // defined(OS_ANDROID)

244 IPC_STRUCT_TRAITS_MEMBER(cross_origin_media_playback_requires_user_gesture)	245 IPC_STRUCT_TRAITS_MEMBER(cross_origin_media_playback_requires_user_gesture)

245 #endif // defined(OS_ANDROID)	246 #endif // defined(OS_ANDROID)

246 IPC_STRUCT_TRAITS_MEMBER(default_minimum_page_scale_factor)	247 IPC_STRUCT_TRAITS_MEMBER(default_minimum_page_scale_factor)

247 IPC_STRUCT_TRAITS_MEMBER(default_maximum_page_scale_factor)	248 IPC_STRUCT_TRAITS_MEMBER(default_maximum_page_scale_factor)

248 IPC_STRUCT_TRAITS_MEMBER(hide_download_ui)	249 IPC_STRUCT_TRAITS_MEMBER(hide_download_ui)

249 IPC_STRUCT_TRAITS_MEMBER(background_video_track_optimization_enabled)	250 IPC_STRUCT_TRAITS_MEMBER(background_video_track_optimization_enabled)

250 IPC_STRUCT_TRAITS_MEMBER(max_keyframe_distance_to_disable_background_video)	251 IPC_STRUCT_TRAITS_MEMBER(max_keyframe_distance_to_disable_background_video)

251 IPC_STRUCT_TRAITS_MEMBER(enable_instant_source_buffer_gc)	252 IPC_STRUCT_TRAITS_MEMBER(enable_instant_source_buffer_gc)

252 IPC_STRUCT_TRAITS_MEMBER(presentation_receiver)	253 IPC_STRUCT_TRAITS_MEMBER(presentation_receiver)

(...skipping 29 matching lines...) Expand all Loading...
282 IPC_ENUM_TRAITS_MAX_VALUE(ui::AXTextAffinity, ui::AX_TEXT_AFFINITY_LAST)	283 IPC_ENUM_TRAITS_MAX_VALUE(ui::AXTextAffinity, ui::AX_TEXT_AFFINITY_LAST)

283 IPC_ENUM_TRAITS_MAX_VALUE(ui::AXEventFrom, ui::AX_EVENT_FROM_LAST)	284 IPC_ENUM_TRAITS_MAX_VALUE(ui::AXEventFrom, ui::AX_EVENT_FROM_LAST)

284	285

285 IPC_STRUCT_TRAITS_BEGIN(ui::AXRelativeBounds)	286 IPC_STRUCT_TRAITS_BEGIN(ui::AXRelativeBounds)

286 IPC_STRUCT_TRAITS_MEMBER(offset_container_id)	287 IPC_STRUCT_TRAITS_MEMBER(offset_container_id)

287 IPC_STRUCT_TRAITS_MEMBER(bounds)	288 IPC_STRUCT_TRAITS_MEMBER(bounds)

288 IPC_STRUCT_TRAITS_MEMBER(transform)	289 IPC_STRUCT_TRAITS_MEMBER(transform)

289 IPC_STRUCT_TRAITS_END()	290 IPC_STRUCT_TRAITS_END()

290	291

291 #endif // CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_	292 #endif // CONTENT_PUBLIC_COMMON_COMMON_PARAM_TRAITS_MACROS_H_

OLD	NEW