Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 26929004: Add periodic check to see if context has been reset (Closed)

Created:
7 years, 2 months ago by oshima
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add periodic check to see if context has been reset. Context may be set to NULL when shutdown is requested while trying to send ping. With this CL, rlz will cancel the request when it detects the NULL context. non chromeos chrome used to wait even after context is set to NULL, so maybe I should do this only for chromeos. Please let me know what you think. This also fixes the edge race case where the g_context may be set to NULL in the middle of FinancialPing::PingServer. BUG=261377 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229114

Patch Set 1 : #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -16 lines) Patch
M rlz/lib/financial_ping.h View 1 chunk +7 lines, -0 lines 0 comments Download
M rlz/lib/financial_ping.cc View 1 2 7 chunks +62 lines, -6 lines 0 comments Download
M rlz/lib/rlz_lib_test.cc View 4 chunks +57 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
7 years, 2 months ago (2013-10-16 23:36:06 UTC) #1
Roger Tawa OOO till Jul 10th
Looks good Mitsuru. Since g_context is being read and written from different threads, maybe it ...
7 years, 2 months ago (2013-10-17 00:18:18 UTC) #2
oshima
On 2013/10/17 00:18:18, Roger Tawa wrote: > Looks good Mitsuru. > > Since g_context is ...
7 years, 2 months ago (2013-10-17 00:55:56 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm Thanks Mitsuru! A couple of comments below. https://codereview.chromium.org/26929004/diff/21001/rlz/lib/financial_ping.cc File rlz/lib/financial_ping.cc (right): https://codereview.chromium.org/26929004/diff/21001/rlz/lib/financial_ping.cc#newcode193 rlz/lib/financial_ping.cc:193: reinterpret_cast<AtomicWord>(context)); ...
7 years, 2 months ago (2013-10-17 01:03:21 UTC) #4
oshima
https://codereview.chromium.org/26929004/diff/21001/rlz/lib/financial_ping.cc File rlz/lib/financial_ping.cc (right): https://codereview.chromium.org/26929004/diff/21001/rlz/lib/financial_ping.cc#newcode193 rlz/lib/financial_ping.cc:193: reinterpret_cast<AtomicWord>(context)); On 2013/10/17 01:03:22, Roger Tawa wrote: > Do ...
7 years, 2 months ago (2013-10-17 01:09:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/26929004/29001
7 years, 2 months ago (2013-10-17 01:46:15 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 03:33:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/26929004/29001
7 years, 2 months ago (2013-10-17 03:49:18 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 2 months ago (2013-10-17 05:29:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/26929004/29001
7 years, 2 months ago (2013-10-17 05:32:29 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 13:12:25 UTC) #11
Message was sent while issue was closed.
Change committed as 229114

Powered by Google App Engine
This is Rietveld 408576698