base/task_scheduler/scheduler_worker_stack_unittest.cc - Issue 2692863012: SchedulerWorker Refcounting for Destruction in Production

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_worker_stack_unittest.cc

Issue 2692863012: SchedulerWorker Refcounting for Destruction in Production (Closed)

Patch Set: Remove Last Vestiges of std::unique_ptr SchedulerWorker Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/scheduler_worker_stack_unittest.cc

diff --git a/base/task_scheduler/scheduler_worker_stack_unittest.cc b/base/task_scheduler/scheduler_worker_stack_unittest.cc

index 520e52cd61f556ff52952fc63284d71ab162b2bf..b7d57ff1ef16623d7c0acb35e5af7e5efb7ae795 100644

--- a/base/task_scheduler/scheduler_worker_stack_unittest.cc

+++ b/base/task_scheduler/scheduler_worker_stack_unittest.cc

@@ -67,9 +67,9 @@ class TaskSchedulerWorkerStackTest : public testing::Test {

worker_c_->JoinForTesting();

}

- std::unique_ptr<SchedulerWorker> worker_a_;

- std::unique_ptr<SchedulerWorker> worker_b_;

- std::unique_ptr<SchedulerWorker> worker_c_;

+ scoped_refptr<SchedulerWorker> worker_a_;

+ scoped_refptr<SchedulerWorker> worker_b_;

+ scoped_refptr<SchedulerWorker> worker_c_;

private:

TaskTracker task_tracker_;