media/base/android/android_overlay.cc - Issue 2692863011: Add ContentVideoViewOverlay to AVDA.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/android/android_overlay.cc

Issue 2692863011: Add ContentVideoViewOverlay to AVDA. (Closed)

Patch Set: keep |overlay| longer in UpdateSurface, comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "media/base/android/android_overlay.h"

	6

	7 namespace media {

	8

	9 AndroidOverlay::Config::Config() = default;

	10 AndroidOverlay::Config::Config(const AndroidOverlay::Config&) = default;

	11 AndroidOverlay::Config::~Config() = default;

	12

	13 AndroidOverlay::AndroidOverlay() {}
	watk 2017/02/17 22:40:35 can write "= default" here too can write "= default" here too liberato (no reviews please) 2017/03/07 21:30:25 true. these are moved to the header anyway now th Show quoted text On 2017/02/17 22:40:35, watk wrote: > can write "= default" here too true. these are moved to the header anyway now that \|surface_\| isn't needed.
	14

	15 AndroidOverlay::~AndroidOverlay() {}

	16

	17 void AndroidOverlay::SetJavaSurface(gl::ScopedJavaSurface surface) {

	18 surface_ = std::move(surface);

	19 }

	20

	21 } // namespace media

OLD	NEW