Use universal references in templated analysis passthrough functions.

base/logging.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_LOGGING_H_
 #define BASE_LOGGING_H_
 
 #include <stddef.h>
 
 #include <cassert>
 #include <cstring>
+#include <memory>

[danakj, 2017/02/14 22:39:31]

forward is in <utility> tho

[Kevin M, 2017/02/14 22:41:01]

Done.

 #include <sstream>
 #include <string>
 #include <type_traits>
 #include <utility>
 
 #include "base/base_export.h"
 #include "base/compiler_specific.h"
 #include "base/debug/debugger.h"
 #include "base/macros.h"
 #include "base/template_util.h"
@@ skipping 269 matching lines @@
 
 // ANALYZER_ASSUME_TRUE(...) generates compiler-specific annotations which
 // prevent the static analyzer from analyzing the code using hypothetical
 // values that are asserted to be impossible.
 // The value of the condition passed to ANALYZER_ASSUME_TRUE() is returned
 // directly.
 #if defined(__clang_analyzer__)
 
 inline void AnalyzerNoReturn() __attribute__((analyzer_noreturn)) {}
 
+// |arg| is a universal reference for compatibility with lvalue and rvalue
+// arguments.
 template <typename TVal>
-inline constexpr TVal AnalysisAssumeTrue(TVal arg) {
+inline constexpr TVal&& AnalysisAssumeTrue(TVal&& arg) {
   if (!arg) {
     AnalyzerNoReturn();
   }
-  return arg;
+  return std::forward<TVal>(arg);
 }
 
 #define ANALYZER_ASSUME_TRUE(val) ::logging::AnalysisAssumeTrue(val)
 
 #elif defined(_PREFAST_) && defined(OS_WIN)
 
+// |arg| is a universal reference for compatibility with lvalue and rvalue
+// arguments.
 template <typename TVal>
-inline constexpr TVal AnalysisAssumeTrue(TVal arg) {
+inline constexpr TVal&& AnalysisAssumeTrue(TVal&& arg) {
   __analysis_assume(!!arg);
-  return arg;
+  return std::forward<TVal>(arg);
 }
 
 #define ANALYZER_ASSUME_TRUE(val) ::logging::AnalysisAssumeTrue(val)
 
 #else  // !_PREFAST_ & !__clang_analyzer__
 
 #define ANALYZER_ASSUME_TRUE(val) (val)
 
 #endif  // !_PREFAST_ & !__clang_analyzer__
 
@@ skipping 724 matching lines @@
 #elif NOTIMPLEMENTED_POLICY == 5
 #define NOTIMPLEMENTED() do {\
   static bool logged_once = false;\
   LOG_IF(ERROR, !logged_once) << NOTIMPLEMENTED_MSG;\
   logged_once = true;\
 } while(0);\
 EAT_STREAM_PARAMETERS
 #endif
 
 #endif  // BASE_LOGGING_H_