Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3221)

Unified Diff: chrome/installer/mini_installer/configuration_test.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)
Patch Set: sync to position 450085 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mini_installer/configuration_test.cc
diff --git a/chrome/installer/mini_installer/configuration_test.cc b/chrome/installer/mini_installer/configuration_test.cc
index 89b6ffe6f3b6067c71ba8998c282893fe1d7db87..b1f3400fd9c1dac1b30dc8ffb06e77095839cfe3 100644
--- a/chrome/installer/mini_installer/configuration_test.cc
+++ b/chrome/installer/mini_installer/configuration_test.cc
@@ -52,9 +52,13 @@ class TestConfiguration : public Configuration {
class MiniInstallerConfigurationTest : public ::testing::Test {
protected:
- MiniInstallerConfigurationTest() {
- registry_overrides_.OverrideRegistry(HKEY_CURRENT_USER);
- registry_overrides_.OverrideRegistry(HKEY_LOCAL_MACHINE);
+ MiniInstallerConfigurationTest() = default;
+
+ void SetUp() override {
+ ASSERT_NO_FATAL_FAILURE(
+ registry_overrides_.OverrideRegistry(HKEY_CURRENT_USER));
+ ASSERT_NO_FATAL_FAILURE(
+ registry_overrides_.OverrideRegistry(HKEY_LOCAL_MACHINE));
}
// Adds sufficient state in the registry for Configuration to think that
« no previous file with comments | « chrome/installer/gcapi/gcapi_test_registry_overrider.cc ('k') | chrome/installer/setup/installer_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698