Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: chrome/install_static/install_util_unittest.cc

Issue 2692843002: Fail tests fast if overriding the Windows registry fails. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/install_static/install_util_unittest.cc
diff --git a/chrome/install_static/install_util_unittest.cc b/chrome/install_static/install_util_unittest.cc
index b4ba97b79e10256a3d35ea41863f470f2216afe1..55775cdd8cf84acb1625e63720a56a9ebebf440e 100644
--- a/chrome/install_static/install_util_unittest.cc
+++ b/chrome/install_static/install_util_unittest.cc
@@ -287,10 +287,6 @@ class InstallStaticUtilTest
details->set_channel(mode_->default_channel_name);
details->set_system_level(system_level_);
InstallDetails::SetForProcess(std::move(details));
-
- base::string16 path;
- override_manager_.OverrideRegistry(root_key_, &path);
- nt::SetTestingOverride(nt_root_key_, path);
}
~InstallStaticUtilTest() {
@@ -298,6 +294,13 @@ class InstallStaticUtilTest
nt::SetTestingOverride(nt_root_key_, base::string16());
}
+ void SetUp() override {
+ base::string16 path;
+ ASSERT_NO_FATAL_FAILURE(
+ override_manager_.OverrideRegistry(root_key_, &path));
+ nt::SetTestingOverride(nt_root_key_, path);
+ }
+
bool system_level() const { return system_level_; }
const wchar_t* default_channel() const { return mode_->default_channel_name; }

Powered by Google App Engine
This is Rietveld 408576698