Fail tests fast if overriding the Windows registry fails.

chrome/installer/setup/setup_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/setup_util_unittest.h"
 
 #include <windows.h>
 #include <shlobj.h>
 
 #include <memory>
@@ skipping 179 matching lines @@
   ASSERT_FALSE(CurrentProcessHasPrivilege(kTestedPrivilege));
 }
 
 TEST(SetupUtilTest, GuidToSquid) {
   ASSERT_EQ(installer::GuidToSquid(L"EDA620E3-AA98-3846-B81E-3493CB2E0E02"),
             L"3E026ADE89AA64838BE14339BCE2E020");
 }
 
 TEST(SetupUtilTest, RegisterEventLogProvider) {
   registry_util::RegistryOverrideManager registry_override_manager;
-  registry_override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE);
+  ASSERT_NO_FATAL_FAILURE(
+      registry_override_manager.OverrideRegistry(HKEY_LOCAL_MACHINE));
 
   const base::Version version("1.2.3.4");
   const base::FilePath install_directory(
       FILE_PATH_LITERAL("c:\\some_path\\test"));
   installer::RegisterEventLogProvider(install_directory, version);
 
   // TODO(grt): use install_static::InstallDetails::Get().install_full_name()
   // when InstallDetails is initialized in the installer.
   base::string16 reg_path(
       L"SYSTEM\\CurrentControlSet\\Services\\EventLog\\Application\\");
@@ skipping 156 matching lines @@
 
     void set_uninstall_command(const base::CommandLine& uninstall_command) {
       uninstall_command_ = uninstall_command;
     }
   };
 
   FindArchiveToPatchTest() {}
 
   void SetUp() override {
     ASSERT_TRUE(test_dir_.CreateUniqueTempDir());
-    registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
-    registry_override_manager_.OverrideRegistry(HKEY_LOCAL_MACHINE);
+    ASSERT_NO_FATAL_FAILURE(
+        registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER));
+    ASSERT_NO_FATAL_FAILURE(
+        registry_override_manager_.OverrideRegistry(HKEY_LOCAL_MACHINE));
     product_version_ = base::Version("30.0.1559.0");
     max_version_ = base::Version("47.0.1559.0");
 
     // Install the product according to the version.
     original_state_.reset(new FakeInstallationState());
     InstallProduct();
 
     // Prepare to update the product in the temp dir.
     installer_state_.reset(new installer::InstallerState(
         kSystemInstall_ ? installer::InstallerState::SYSTEM_LEVEL :
@@ skipping 134 matching lines @@
                              base::CompareCase::SENSITIVE));
 }
 
 namespace installer {
 
 class DeleteRegistryKeyPartialTest : public ::testing::Test {
  protected:
   using RegKey = base::win::RegKey;
 
   void SetUp() override {
-    _registry_override_manager.OverrideRegistry(root_);
+    ASSERT_NO_FATAL_FAILURE(_registry_override_manager.OverrideRegistry(root_));
     to_preserve_.push_back(L"preSERve1");
     to_preserve_.push_back(L"1evRESerp");
   }
 
   void CreateSubKeys(bool with_preserves) {
     ASSERT_FALSE(RegKey(root_, path_.c_str(), KEY_READ).Valid());
     // These subkeys are added such that 1) keys to preserve are intermixed with
     // other keys, and 2) the case of the keys to preserve doesn't match the
     // values in |to_preserve_|.
     ASSERT_EQ(ERROR_SUCCESS, RegKey(root_, path_.c_str(), KEY_WRITE)
@@ skipping 90 matching lines @@
     base::win::RegistryValueIterator it(root_, path_.c_str());
     ASSERT_EQ(0u, it.ValueCount());
   }
 }
 
 class LegacyCleanupsTest : public ::testing::Test {
  protected:
   LegacyCleanupsTest() = default;
   void SetUp() override {
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
-    registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER);
+    ASSERT_NO_FATAL_FAILURE(
+        registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER));
     installer_state_ =
         base::MakeUnique<FakeInstallerState>(temp_dir_.GetPath());
     // Create the state to be cleared.
     ASSERT_TRUE(base::win::RegKey(HKEY_CURRENT_USER, kBinariesClientsKeyPath,
                                   KEY_WRITE | KEY_WOW64_32KEY)
                     .Valid());
 #if defined(GOOGLE_CHROME_BUILD)
     ASSERT_TRUE(base::win::RegKey(HKEY_CURRENT_USER, kGCFClientsKeyPath,
                                   KEY_WRITE | KEY_WOW64_32KEY)
                     .Valid());
@@ skipping 112 matching lines @@
   EXPECT_FALSE(HasBinariesVersionKey());
 #if defined(GOOGLE_CHROME_BUILD)
   EXPECT_FALSE(HasMultiGCFVersionKey());
   EXPECT_FALSE(HasAppLauncherVersionKey());
   EXPECT_FALSE(HasAppHostExe());
   EXPECT_FALSE(HasInstallExtensionCommand());
 #endif  // GOOGLE_CHROME_BUILD
 }
 
 }  // namespace installer