Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269283008: Refactor deprecated Skia calls. (Closed)

Created:
6 years, 7 months ago by f(malita)
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Refactor deprecated Skia calls. Use equivalent non-deprecated methods instead. R=reed@google.com,senorblanco@chromium.org,abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173553

Patch Set 1 #

Total comments: 2

Patch Set 2 : SkiaUtils InterpolationQuality helper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContextState.cpp View 1 3 chunks +6 lines, -4 lines 0 comments Download
M Source/platform/graphics/skia/SkiaUtils.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
f(malita)
6 years, 7 months ago (2014-05-07 15:59:35 UTC) #1
reed1
lgtm
6 years, 7 months ago (2014-05-07 16:14:21 UTC) #2
Stephen White
LGTM https://codereview.chromium.org/269283008/diff/1/Source/platform/graphics/GraphicsContextState.cpp File Source/platform/graphics/GraphicsContextState.cpp (right): https://codereview.chromium.org/269283008/diff/1/Source/platform/graphics/GraphicsContextState.cpp#newcode34 Source/platform/graphics/GraphicsContextState.cpp:34: m_fillPaint.setFilterLevel(m_interpolationQuality != InterpolationNone Nit: maybe we should have ...
6 years, 7 months ago (2014-05-07 16:40:47 UTC) #3
abarth-chromium
rslgtm
6 years, 7 months ago (2014-05-07 17:15:49 UTC) #4
f(malita)
https://codereview.chromium.org/269283008/diff/1/Source/platform/graphics/GraphicsContextState.cpp File Source/platform/graphics/GraphicsContextState.cpp (right): https://codereview.chromium.org/269283008/diff/1/Source/platform/graphics/GraphicsContextState.cpp#newcode34 Source/platform/graphics/GraphicsContextState.cpp:34: m_fillPaint.setFilterLevel(m_interpolationQuality != InterpolationNone On 2014/05/07 16:40:47, Stephen White wrote: ...
6 years, 7 months ago (2014-05-07 17:53:26 UTC) #5
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 7 months ago (2014-05-07 18:24:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/269283008/20001
6 years, 7 months ago (2014-05-07 18:25:16 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 19:05:22 UTC) #8
Message was sent while issue was closed. 
Change committed as 173553

Powered by Google App Engine
This is Rietveld 408576698