Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: sdk/lib/async/stream.dart

Issue 269283007: Make errors from StreamController onCancel calls end up in the returned future. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/async/stream_controller.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream.dart
diff --git a/sdk/lib/async/stream.dart b/sdk/lib/async/stream.dart
index e612b9cc5ff4dcfdca883c3674193407d74c13f6..a3b266f4f3b37b990dd777fe8fa1a4233bcd9e49 100644
--- a/sdk/lib/async/stream.dart
+++ b/sdk/lib/async/stream.dart
@@ -1174,6 +1174,11 @@ abstract class StreamSubscription<T> {
* for example a file being read, that should be deleted afterwards.
* In that case, the file may not be able to be deleted successfully
* until the returned future has completed.
+ *
+ * The future will be completed with a `null` value.
+ * If the cleanup throws, which it really shouldn't, the returned future
+ * will be completed with that error.
+ *
* Returns `null` if there is no need to wait.
*/
Future cancel();
« no previous file with comments | « no previous file | sdk/lib/async/stream_controller.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698