Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: net/tools/quic/quic_simple_server_session_test.cc

Issue 2692813002: Server push cancellation: add a finch trial parameter (Closed)
Patch Set: sync with internal code Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/quic/quic_simple_server_session_test.cc
diff --git a/net/tools/quic/quic_simple_server_session_test.cc b/net/tools/quic/quic_simple_server_session_test.cc
index 5d1cac27f33fa9561f04ef3a48ad79b1aa7d800f..35db6162aa326a698f28592e9254e1bbb679a875 100644
--- a/net/tools/quic/quic_simple_server_session_test.cc
+++ b/net/tools/quic/quic_simple_server_session_test.cc
@@ -235,6 +235,7 @@ TEST_P(QuicSimpleServerSessionTest, CloseStreamDueToReset) {
// Receive a reset (and send a RST in response).
QuicRstStreamFrame rst1(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM,
0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst1);
@@ -252,6 +253,7 @@ TEST_P(QuicSimpleServerSessionTest, NeverOpenStreamDueToReset) {
// Send a reset (and expect the peer to send a RST in response).
QuicRstStreamFrame rst1(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM,
0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst1);
@@ -278,6 +280,7 @@ TEST_P(QuicSimpleServerSessionTest, AcceptClosedStream) {
// Send a reset (and expect the peer to send a RST in response).
QuicRstStreamFrame rst(kClientDataStreamId1, QUIC_ERROR_PROCESSING_STREAM, 0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(kClientDataStreamId1, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst);
@@ -569,6 +572,7 @@ TEST_P(QuicSimpleServerSessionServerPushTest,
// Reset the last stream in the queue. It should be marked cancelled.
QuicStreamId stream_got_reset = num_resources * 2;
QuicRstStreamFrame rst(stream_got_reset, QUIC_STREAM_CANCELLED, 0);
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
EXPECT_CALL(*connection_,
SendRstStream(stream_got_reset, QUIC_RST_ACKNOWLEDGEMENT, 0));
visitor_->OnRstStream(rst);
@@ -613,6 +617,7 @@ TEST_P(QuicSimpleServerSessionServerPushTest,
.WillOnce(Return(QuicConsumedData(kStreamFlowControlWindowSize, false)));
EXPECT_CALL(*connection_, SendBlocked(stream_to_open));
+ EXPECT_CALL(owner_, OnRstStreamReceived(_)).Times(1);
QuicRstStreamFrame rst(stream_got_reset, QUIC_STREAM_CANCELLED, 0);
visitor_->OnRstStream(rst);
}

Powered by Google App Engine
This is Rietveld 408576698