Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: runtime/vm/scopes.cc

Issue 2692803006: Track the 'awaiter return' call stack use it to detect uncaught exceptions in async functions (Closed)
Patch Set: rmacnak review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/scopes.cc
diff --git a/runtime/vm/scopes.cc b/runtime/vm/scopes.cc
index 75f5d688bf59de6de2765c8cbac70974820850f5..e7c04323367039040209ec798b4ba7870dddae1e 100644
--- a/runtime/vm/scopes.cc
+++ b/runtime/vm/scopes.cc
@@ -264,6 +264,18 @@ static bool IsFilteredIdentifier(const String& str) {
// Keep :async_op for asynchronous debugging.
return false;
}
+ if (str.raw() == Symbols::AsyncCompleter().raw()) {
+ // Keep :async_completer for asynchronous debugging.
+ return false;
+ }
+ if (str.raw() == Symbols::ControllerStream().raw()) {
+ // Keep :controller_stream for asynchronous debugging.
+ return false;
+ }
+ if (str.raw() == Symbols::AwaitJumpVar().raw()) {
+ // Keep :await_jump_var for asynchronous debugging.
+ return false;
+ }
return str.CharAt(0) == ':';
}

Powered by Google App Engine
This is Rietveld 408576698