[turbofan] escape analysis supports arguments object and rest elements

src/builtins/builtins-internal.cc

Index: src/builtins/builtins-internal.cc
diff --git a/src/builtins/builtins-internal.cc b/src/builtins/builtins-internal.cc
index f94ed0c16f2f6de091dfbd7da2f3077159fd3a89..f5773eb996ee8413ba366082b70b77e3bcd1a78e 100644
--- a/src/builtins/builtins-internal.cc
+++ b/src/builtins/builtins-internal.cc
@@ -225,88 +225,13 @@ void Generate_NewArgumentsElements(CodeStubAssembler* assembler,
 
 void Builtins::Generate_NewUnmappedArgumentsElements(
     compiler::CodeAssemblerState* state) {
-  typedef CodeStubAssembler::Label Label;
-  typedef CodeStubAssembler::Variable Variable;
-  typedef compiler::Node Node;
-  typedef NewArgumentsElementsDescriptor Descriptor;
-  CodeStubAssembler assembler(state);
-
-  Node* formal_parameter_count =
-      assembler.Parameter(Descriptor::kFormalParameterCount);
-
-  // Determine the frame that holds the parameters.
-  Label done(&assembler);
-  Variable var_frame(&assembler, MachineType::PointerRepresentation()),
-      var_length(&assembler, MachineType::PointerRepresentation());
-  var_frame.Bind(assembler.LoadParentFramePointer());
-  var_length.Bind(formal_parameter_count);
-  Node* parent_frame = assembler.Load(
-      MachineType::Pointer(), var_frame.value(),
-      assembler.IntPtrConstant(StandardFrameConstants::kCallerFPOffset));
-  Node* parent_frame_type =
-      assembler.Load(MachineType::AnyTagged(), parent_frame,
-                     assembler.IntPtrConstant(
-                         CommonFrameConstants::kContextOrFrameTypeOffset));
-  assembler.GotoUnless(
-      assembler.WordEqual(
-          parent_frame_type,
-          assembler.SmiConstant(Smi::FromInt(StackFrame::ARGUMENTS_ADAPTOR))),
-      &done);
-  {
-    // Determine the length from the ArgumentsAdaptorFrame.
-    Node* length = assembler.LoadAndUntagSmi(
-        parent_frame, ArgumentsAdaptorFrameConstants::kLengthOffset);
-
-    // Take the arguments from the ArgumentsAdaptorFrame.
-    var_frame.Bind(parent_frame);
-    var_length.Bind(length);
-  }
-  assembler.Goto(&done);
-
-  // Allocate the actual FixedArray for the elements.
-  assembler.Bind(&done);
-  Generate_NewArgumentsElements(&assembler, var_frame.value(),
-                                var_length.value());
-}
-
-void Builtins::Generate_NewRestParameterElements(
-    compiler::CodeAssemblerState* state) {
-  typedef CodeStubAssembler::Label Label;
   typedef compiler::Node Node;
   typedef NewArgumentsElementsDescriptor Descriptor;
   CodeStubAssembler assembler(state);
 
-  Node* formal_parameter_count =
-      assembler.Parameter(Descriptor::kFormalParameterCount);
-
-  // Check if we have an ArgumentsAdaptorFrame, as we will only have rest
-  // parameters in that case.
-  Label if_empty(&assembler);
-  Node* frame = assembler.Load(
-      MachineType::Pointer(), assembler.LoadParentFramePointer(),
-      assembler.IntPtrConstant(StandardFrameConstants::kCallerFPOffset));
-  Node* frame_type =
-      assembler.Load(MachineType::AnyTagged(), frame,
-                     assembler.IntPtrConstant(
-                         CommonFrameConstants::kContextOrFrameTypeOffset));
-  assembler.GotoUnless(
-      assembler.WordEqual(frame_type, assembler.SmiConstant(Smi::FromInt(
-                                          StackFrame::ARGUMENTS_ADAPTOR))),
-      &if_empty);
-
-  // Determine the length from the ArgumentsAdaptorFrame.
-  Node* frame_length = assembler.LoadAndUntagSmi(
-      frame, ArgumentsAdaptorFrameConstants::kLengthOffset);
-
-  // Compute the actual rest parameter length (may be negative).
-  Node* length = assembler.IntPtrSub(frame_length, formal_parameter_count);
-
-  // Allocate the actual FixedArray for the elements.
-  Generate_NewArgumentsElements(&assembler, frame, length);
-
-  // No rest parameters, return an empty FixedArray.
-  assembler.Bind(&if_empty);
-  assembler.Return(assembler.EmptyFixedArrayConstant());
+  Node* frame = assembler.Parameter(Descriptor::kFrame);
+  Node* length = assembler.Parameter(Descriptor::kLength);
+  Generate_NewArgumentsElements(&assembler, frame, assembler.SmiToWord(length));
 }
 
 void Builtins::Generate_ReturnReceiver(compiler::CodeAssemblerState* state) {