Issue 269273003: Fix index register assignment in LoadFieldByIndex for arm, arm64, and mips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269273003: Fix index register assignment in LoadFieldByIndex for arm, arm64, and mips. (Closed)

Created:
6 years, 7 months ago by ulan

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix index register assignment in LoadFieldByIndex for arm, arm64, and mips. This instruciton clobbers the index register. BUG=368243 LOG=N TEST=mjsunit/regress/regress-368243 R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21196

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix whitespace in test #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -14 lines)			Patch
M	src/arm/lithium-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/lithium-arm64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/lithium-mips.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-368243.js	View	1	1 chunk	+16 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM https://codereview.chromium.org/269273003/diff/1/test/mjsunit/regress/regress-368243.js File test/mjsunit/regress/regress-368243.js (right): https://codereview.chromium.org/269273003/diff/1/test/mjsunit/regress/regress-368243.js#newcode10 test/mjsunit/regress/regress-368243.js:10: a[f]=c[f]; nit: spaces around '=' (and ',' in ...

6 years, 7 months ago (2014-05-07 16:16:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r21196 (tree was closed).

Expand Messages | Collapse Messages