Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2692663002: Gut ash::MaterialDesignController, and remove the about:flags entry. (Closed)
Patch Set: terry review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 const FeatureEntry::Choice kTopChromeMaterialDesignChoices[] = { 379 const FeatureEntry::Choice kTopChromeMaterialDesignChoices[] = {
380 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" }, 380 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
381 { IDS_FLAGS_TOP_CHROME_MD_MATERIAL, 381 { IDS_FLAGS_TOP_CHROME_MD_MATERIAL,
382 switches::kTopChromeMD, 382 switches::kTopChromeMD,
383 switches::kTopChromeMDMaterial }, 383 switches::kTopChromeMDMaterial },
384 { IDS_FLAGS_TOP_CHROME_MD_MATERIAL_HYBRID, 384 { IDS_FLAGS_TOP_CHROME_MD_MATERIAL_HYBRID,
385 switches::kTopChromeMD, 385 switches::kTopChromeMD,
386 switches::kTopChromeMDMaterialHybrid }, 386 switches::kTopChromeMDMaterialHybrid },
387 }; 387 };
388 388
389 #if defined(USE_ASH)
390 const FeatureEntry::Choice kAshMaterialDesignChoices[] = {
391 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
392 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, ash::switches::kAshMaterialDesign,
393 ash::switches::kAshMaterialDesignDisabled},
394 {IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED, ash::switches::kAshMaterialDesign,
395 ash::switches::kAshMaterialDesignEnabled},
396 {IDS_FLAGS_ASH_MD_EXPERIMENTAL, ash::switches::kAshMaterialDesign,
397 ash::switches::kAshMaterialDesignExperimental},
398 };
399 #endif // USE_ASH
400
401 #if defined(OS_CHROMEOS) 389 #if defined(OS_CHROMEOS)
402 const FeatureEntry::Choice kAshMaterialDesignInkDropAnimationSpeed[] = { 390 const FeatureEntry::Choice kAshMaterialDesignInkDropAnimationSpeed[] = {
403 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 391 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
404 {IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_FAST, 392 {IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_FAST,
405 switches::kMaterialDesignInkDropAnimationSpeed, 393 switches::kMaterialDesignInkDropAnimationSpeed,
406 switches::kMaterialDesignInkDropAnimationSpeedFast}, 394 switches::kMaterialDesignInkDropAnimationSpeedFast},
407 {IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SLOW, 395 {IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SLOW,
408 switches::kMaterialDesignInkDropAnimationSpeed, 396 switches::kMaterialDesignInkDropAnimationSpeed,
409 switches::kMaterialDesignInkDropAnimationSpeedSlow}}; 397 switches::kMaterialDesignInkDropAnimationSpeedSlow}};
410 398
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1016 { 1004 {
1017 "ash-enable-docked-windows", IDS_FLAGS_ASH_ENABLE_DOCKED_WINDOWS_NAME, 1005 "ash-enable-docked-windows", IDS_FLAGS_ASH_ENABLE_DOCKED_WINDOWS_NAME,
1018 IDS_FLAGS_ASH_ENABLE_DOCKED_WINDOWS_DESCRIPTION, kOsAll, 1006 IDS_FLAGS_ASH_ENABLE_DOCKED_WINDOWS_DESCRIPTION, kOsAll,
1019 SINGLE_VALUE_TYPE(ash::switches::kAshEnableDockedWindows), 1007 SINGLE_VALUE_TYPE(ash::switches::kAshEnableDockedWindows),
1020 }, 1008 },
1021 { 1009 {
1022 "ash-enable-mirrored-screen", IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_NAME, 1010 "ash-enable-mirrored-screen", IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_NAME,
1023 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_DESCRIPTION, kOsCrOS, 1011 IDS_FLAGS_ASH_ENABLE_MIRRORED_SCREEN_DESCRIPTION, kOsCrOS,
1024 SINGLE_VALUE_TYPE(ash::switches::kAshEnableMirroredScreen), 1012 SINGLE_VALUE_TYPE(ash::switches::kAshEnableMirroredScreen),
1025 }, 1013 },
1026 {"ash-md", IDS_FLAGS_ASH_MD, IDS_FLAGS_ASH_MD_DESCRIPTION, kOsCrOS,
1027 MULTI_VALUE_TYPE(kAshMaterialDesignChoices)},
1028 #endif // USE_ASH 1014 #endif // USE_ASH
1029 #if defined(OS_CHROMEOS) 1015 #if defined(OS_CHROMEOS)
1030 {"material-design-ink-drop-animation-speed", 1016 {"material-design-ink-drop-animation-speed",
1031 IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SPEED_NAME, 1017 IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SPEED_NAME,
1032 IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SPEED_DESCRIPTION, kOsCrOS, 1018 IDS_FLAGS_MATERIAL_DESIGN_INK_DROP_ANIMATION_SPEED_DESCRIPTION, kOsCrOS,
1033 MULTI_VALUE_TYPE(kAshMaterialDesignInkDropAnimationSpeed)}, 1019 MULTI_VALUE_TYPE(kAshMaterialDesignInkDropAnimationSpeed)},
1034 {"ui-slow-animations", IDS_FLAGS_UI_SLOW_ANIMATIONS_NAME, 1020 {"ui-slow-animations", IDS_FLAGS_UI_SLOW_ANIMATIONS_NAME,
1035 IDS_FLAGS_UI_SLOW_ANIMATIONS_DESCRIPTION, kOsCrOS, 1021 IDS_FLAGS_UI_SLOW_ANIMATIONS_DESCRIPTION, kOsCrOS,
1036 SINGLE_VALUE_TYPE(switches::kUISlowAnimations)}, 1022 SINGLE_VALUE_TYPE(switches::kUISlowAnimations)},
1037 {"disable-cloud-import", IDS_FLAGS_CLOUD_IMPORT, 1023 {"disable-cloud-import", IDS_FLAGS_CLOUD_IMPORT,
(...skipping 1372 matching lines...) Expand 10 before | Expand all | Expand 10 after
2410 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2396 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2411 2397
2412 const FeatureEntry* GetFeatureEntries(size_t* count) { 2398 const FeatureEntry* GetFeatureEntries(size_t* count) {
2413 *count = arraysize(kFeatureEntries); 2399 *count = arraysize(kFeatureEntries);
2414 return kFeatureEntries; 2400 return kFeatureEntries;
2415 } 2401 }
2416 2402
2417 } // namespace testing 2403 } // namespace testing
2418 2404
2419 } // namespace about_flags 2405 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698