Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js

Issue 2692653003: [Devtools] Added Enable/Disable for request blocking in network (Closed)
Patch Set: Merge branch 'BLOCK_REQUEST_REMOVE_CONTEXT_MENU' into ADD_ENABLE_DISABLE_REQUEST_BLOCKINg Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
index e38c0457e2ed02ba16965e3b8d5b169cd457d78e..0ebd4ac566bdf3347f26703e35ca4d0476e28baf 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
@@ -24,6 +24,14 @@ Network.BlockedURLsPane = class extends UI.VBox {
clearButton.addEventListener(UI.ToolbarButton.Events.Click, this._removeAll, this);
this._toolbar.appendToolbarItem(clearButton);
+ var enableRequestBlockingCheckbox = new UI.ToolbarCheckbox(
+ Common.UIString('Enable Request Blocking'), Common.UIString('Enables request blocking'), undefined,
+ enableRequestBlockingChecked);
+ SDK.multitargetNetworkManager.on(
+ SDK.MultitargetNetworkManager.RequestBlockingEnabledChangedEvent,
+ event => enableRequestBlockingCheckbox.setChecked(event.enabled));
+ this._toolbar.appendToolbarItem(enableRequestBlockingCheckbox);
+
this._emptyElement = this.contentElement.createChild('div', 'no-blocked-urls');
this._emptyElement.createChild('span').textContent = Common.UIString('Requests are not blocked. ');
var addLink = this._emptyElement.createChild('span', 'link');
@@ -42,6 +50,10 @@ Network.BlockedURLsPane = class extends UI.VBox {
this._updateThrottler = new Common.Throttler(200);
this._update();
+
+ function enableRequestBlockingChecked() {
+ SDK.multitargetNetworkManager.setRequestBlockingEnabled(enableRequestBlockingCheckbox.checked());
+ }
}
static reset() {

Powered by Google App Engine
This is Rietveld 408576698