third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc - Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)

Patch Set: CR fixes, merge w master Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_length_utils_test.cc ('k') | third_party/WebKit/Source/web/tests/NGInlineLayoutTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

index 85d2fe9f999dd0361d568190207eb9824e284c0c..125baf34a943015254cdcc2e589d74df82f75bf1 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc

@@ -59,7 +59,7 @@ NGOutOfFlowLayoutPart::NGOutOfFlowLayoutPart(

space_builder.SetPercentageResolutionSize(space_size);

space_builder.SetIsNewFormattingContext(true);

space_builder.SetTextDirection(container_style_.direction());

- container_space_ = space_builder.ToConstraintSpace();

+ container_space_ = space_builder.ToConstraintSpace(writing_mode);

}

void NGOutOfFlowLayoutPart::Run() {

@@ -178,7 +178,8 @@ RefPtr<NGPhysicalFragment> NGOutOfFlowLayoutPart::GenerateFragment(

builder.SetIsFixedSizeBlock(true);

builder.SetIsFixedSizeInline(true);

builder.SetIsNewFormattingContext(true);

- NGConstraintSpace* space = builder.ToConstraintSpace();

+ NGConstraintSpace* space =

+ builder.ToConstraintSpace(container_space_->WritingMode());

return descendant.Layout(space);

}