Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc

Issue 2692643002: Change how NGConstraintSpaceBuilder specified destination space. (Closed)
Patch Set: CR fixes, merge w master Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
index 334757feb76613089f430ef7e9cc74297451593a..d74585bc488d636a28662d663736b216212afebc 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc
@@ -27,18 +27,14 @@ class NGAbsoluteUtilsTest : public ::testing::Test {
container_size_ = NGLogicalSize(LayoutUnit(200), LayoutUnit(300));
NGConstraintSpaceBuilder builder(kHorizontalTopBottom);
builder.SetAvailableSize(container_size_);
- ltr_space_ = builder.SetWritingMode(kHorizontalTopBottom)
- .SetTextDirection(TextDirection::kLtr)
- .ToConstraintSpace();
- rtl_space_ = builder.SetWritingMode(kHorizontalTopBottom)
- .SetTextDirection(TextDirection::kRtl)
- .ToConstraintSpace();
- vertical_lr_space_ = builder.SetWritingMode(kVerticalLeftRight)
- .SetTextDirection(TextDirection::kLtr)
- .ToConstraintSpace();
- vertical_rl_space_ = builder.SetWritingMode(kVerticalLeftRight)
- .SetTextDirection(TextDirection::kLtr)
- .ToConstraintSpace();
+ ltr_space_ = builder.SetTextDirection(TextDirection::kLtr)
+ .ToConstraintSpace(kHorizontalTopBottom);
+ rtl_space_ = builder.SetTextDirection(TextDirection::kRtl)
+ .ToConstraintSpace(kHorizontalTopBottom);
+ vertical_lr_space_ = builder.SetTextDirection(TextDirection::kLtr)
+ .ToConstraintSpace(kVerticalLeftRight);
+ vertical_rl_space_ = builder.SetTextDirection(TextDirection::kLtr)
+ .ToConstraintSpace(kVerticalRightLeft);
}
void SetHorizontalStyle(LayoutUnit left,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698