third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/durable-storage-on-insecure-origin.html - Issue 2692633002: Use [SecureContext] for navigator.storage

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/durable-storage-on-insecure-origin.html

Issue 2692633002: Use [SecureContext] for navigator.storage (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Request Durable Storage On An Insecure Origin</title>	2 <title>Request Durable Storage On An Insecure Origin</title>

3 <script src="/resources/testharness.js"></script>	3 <script src="/resources/testharness.js"></script>

4 <script src="/resources/testharnessreport.js"></script>	4 <script src="/resources/testharnessreport.js"></script>

5 <script src="/resources/get-host-info.js"></script>	5 <script src="/resources/get-host-info.js"></script>

6 <script>	6 <script>

7 if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {	7 if (window.location.origin != get_host_info().UNAUTHENTICATED_ORIGIN) {

8 window.location = get_host_info().UNAUTHENTICATED_ORIGIN + window.location.p athname;	8 window.location = get_host_info().UNAUTHENTICATED_ORIGIN + window.location.pat hname;

9 } else {	9 } else {

10 promise_test(function(test) {	10 test(function(test) {

11 return promise_rejects(test, 'SecurityError', navigator.storage.persist( ));	11 assert_false('storage' in navigator,

12 }, "Requires secure context");	12 'navigator.storage attribute has [SecureContext]');

	13 }, 'Requires secure context');
	Mike West 2017/02/14 12:39:25 Nit: Are there Web Platform Tests for this feature Nit: Are there Web Platform Tests for this feature? If so, could this test live there? :) jsbell 2017/02/14 18:34:47 We should add a suite/migrate our tests; I'll do t Show quoted text On 2017/02/14 12:39:25, Mike West (sloooooow) wrote: > Nit: Are there Web Platform Tests for this feature? If so, could this test live > there? :) We should add a suite/migrate our tests; I'll do that as a follow-up.
13 }	14 }

14 </script>	15 </script>

OLD	NEW