Media Remoting: End to end integration tests.

media/remoting/end2end_test_renderer.cc

Index: media/remoting/end2end_test_renderer.cc
diff --git a/media/remoting/end2end_test_renderer.cc b/media/remoting/end2end_test_renderer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3dda4d1a6520679811a3ed0fdee32b4ca2bad336
--- /dev/null
+++ b/media/remoting/end2end_test_renderer.cc
@@ -0,0 +1,219 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/remoting/end2end_test_renderer.h"
+
+#include "base/bind.h"
+#include "base/bind_helpers.h"
+#include "base/callback.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "media/mojo/interfaces/remoting.mojom.h"
+#include "media/remoting/courier_renderer.h"
+#include "media/remoting/proto_utils.h"
+#include "media/remoting/remote_receiver.h"
+#include "media/remoting/renderer_controller.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
+
+namespace media {
+namespace remoting {
+
+namespace {
+
+class TestStreamSender final : public mojom::RemotingDataStreamSender {
+ public:
+  using SendFrameToSinkCallback =
+      base::Callback<void(const std::vector<uint8_t>& data,
+                          DemuxerStream::Type type)>;
+  TestStreamSender(mojom::RemotingDataStreamSenderRequest request,
+                   mojo::ScopedDataPipeConsumerHandle handle,
+                   DemuxerStream::Type type,
+                   const SendFrameToSinkCallback& callback)
+      : binding_(this, std::move(request)),
+        consumer_handle_(std::move(handle)),
+        type_(type),
+        send_frame_to_sink_cb_(callback) {}
+
+  ~TestStreamSender() override {}
+
+  // mojom::RemotingDataStreamSender implementation.
+
+  void ConsumeDataChunk(uint32_t offset,
+                        uint32_t size,
+                        uint32_t total_payload_size) override {
+    next_frame_data_.resize(total_payload_size);
+    MojoResult result = mojo::ReadDataRaw(
+        consumer_handle_.get(), next_frame_data_.data() + offset, &size,
+        MOJO_READ_DATA_FLAG_ALL_OR_NONE);
+    CHECK(result == MOJO_RESULT_OK);
+  }
+
+  void SendFrame() override {
+    if (!send_frame_to_sink_cb_.is_null())
+      send_frame_to_sink_cb_.Run(next_frame_data_, type_);
+    next_frame_data_.resize(0);
+  }
+
+  void CancelInFlightData() override { next_frame_data_.resize(0); }
+
+ private:
+  mojo::Binding<RemotingDataStreamSender> binding_;
+  mojo::ScopedDataPipeConsumerHandle consumer_handle_;
+  const DemuxerStream::Type type_;
+  const SendFrameToSinkCallback& send_frame_to_sink_cb_;

[miu, 2017/03/29 01:39:13]

typo: Need to remove ampersand here.

[xjz, 2017/03/30 23:21:30]

Done.

+  std::vector<uint8_t> next_frame_data_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestStreamSender);
+};
+
+class TestRemoter final : public mojom::Remoter {
+ public:
+  using SendMessageToSinkCallback =
+      base::Callback<void(const std::vector<uint8_t>& message)>;
+  TestRemoter(
+      mojom::RemotingSourcePtr source,
+      const SendMessageToSinkCallback& send_message_to_sink_cb,
+      const TestStreamSender::SendFrameToSinkCallback& send_frame_to_sink_cb)
+      : source_(std::move(source)),
+        send_message_to_sink_cb_(send_message_to_sink_cb),
+        send_frame_to_sink_cb_(send_frame_to_sink_cb) {}
+
+  ~TestRemoter() override {}
+
+  // mojom::Remoter implementation.
+
+  void Start() override { source_->OnStarted(); }
+
+  void StartDataStreams(
+      mojo::ScopedDataPipeConsumerHandle audio_pipe,
+      mojo::ScopedDataPipeConsumerHandle video_pipe,
+      mojom::RemotingDataStreamSenderRequest audio_sender_request,
+      mojom::RemotingDataStreamSenderRequest video_sender_request) override {
+    if (audio_pipe.is_valid()) {
+      audio_stream_sender_.reset(new TestStreamSender(
+          std::move(audio_sender_request), std::move(audio_pipe),
+          DemuxerStream::AUDIO, send_frame_to_sink_cb_));
+    }
+    if (video_pipe.is_valid()) {
+      video_stream_sender_.reset(new TestStreamSender(
+          std::move(video_sender_request), std::move(video_pipe),
+          DemuxerStream::VIDEO, send_frame_to_sink_cb_));
+    }
+  }
+
+  void Stop(mojom::RemotingStopReason reason) override {
+    source_->OnStopped(reason);
+  }
+
+  void SendMessageToSink(const std::vector<uint8_t>& message) override {
+    if (!send_message_to_sink_cb_.is_null())
+      send_message_to_sink_cb_.Run(message);
+  }
+
+  // Called when receives RPC messages from receiver.
+  void OnMessageFromSink(const std::vector<uint8_t>& message) {
+    source_->OnMessageFromSink(message);
+  }
+
+ private:
+  mojom::RemotingSourcePtr source_;
+  const SendMessageToSinkCallback send_message_to_sink_cb_;
+  const TestStreamSender::SendFrameToSinkCallback send_frame_to_sink_cb_;
+  std::unique_ptr<TestStreamSender> audio_stream_sender_;
+  std::unique_ptr<TestStreamSender> video_stream_sender_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestRemoter);
+};
+
+scoped_refptr<SharedSession> CreateSharedSession(
+    const TestRemoter::SendMessageToSinkCallback& send_message_to_sink_cb,
+    const TestStreamSender::SendFrameToSinkCallback& send_frame_to_sink_cb) {
+  mojom::RemotingSourcePtr remoting_source;
+  mojom::RemotingSourceRequest remoting_source_request(&remoting_source);
+  mojom::RemoterPtr remoter;
+  std::unique_ptr<TestRemoter> test_remoter = base::MakeUnique<TestRemoter>(
+      std::move(remoting_source), send_message_to_sink_cb,
+      send_frame_to_sink_cb);
+  mojo::MakeStrongBinding(std::move(test_remoter), mojo::MakeRequest(&remoter));
+  return new SharedSession(std::move(remoting_source_request),
+                           std::move(remoter));
+}
+
+}  // namespace
+
+End2EndTestRenderer::End2EndTestRenderer(std::unique_ptr<Renderer> renderer)
+    : receiver_rpc_broker_(base::Bind(&End2EndTestRenderer::OnMessageFromSink,
+                                      base::Unretained(this))),
+      receiver_(new RemoteReceiver(std::move(renderer), &receiver_rpc_broker_)),
+      weak_factory_(this) {
+  shared_session_ =
+      CreateSharedSession(base::Bind(&End2EndTestRenderer::SendMessageToSink,
+                                     weak_factory_.GetWeakPtr()),
+                          base::Bind(&End2EndTestRenderer::SendFrameToSink,
+                                     weak_factory_.GetWeakPtr()));
+  controller_.reset(new RendererController(shared_session_));
+  courier_renderer_.reset(new CourierRenderer(
+      base::ThreadTaskRunnerHandle::Get(), controller_->GetWeakPtr(), nullptr));
+}
+
+End2EndTestRenderer::~End2EndTestRenderer() {}
+
+void End2EndTestRenderer::Initialize(MediaResource* media_resource,
+                                     RendererClient* client,
+                                     const PipelineStatusCB& init_cb) {
+  courier_renderer_->Initialize(media_resource, client, init_cb);
+}
+
+void End2EndTestRenderer::SetCdm(CdmContext* cdm_context,
+                                 const CdmAttachedCB& cdc_attached_cb) {
+  // TODO(xjz): Add the implementation when media remoting starts supporting
+  // encrypted contents.
+  LOG(ERROR) << __func__ << ": Media Remoting doesn't support EME for now.";

[miu, 2017/03/29 01:39:13]

Instead:

  NOTIMPLEMENTED();

[xjz, 2017/03/30 23:21:30]

Done.

+}
+
+void End2EndTestRenderer::Flush(const base::Closure& flush_cb) {
+  courier_renderer_->Flush(flush_cb);
+}
+
+void End2EndTestRenderer::StartPlayingFrom(base::TimeDelta time) {
+  courier_renderer_->StartPlayingFrom(time);
+}
+
+void End2EndTestRenderer::SetPlaybackRate(double playback_rate) {
+  courier_renderer_->SetPlaybackRate(playback_rate);
+}
+
+void End2EndTestRenderer::SetVolume(float volume) {
+  courier_renderer_->SetVolume(volume);
+}
+
+base::TimeDelta End2EndTestRenderer::GetMediaTime() {
+  return courier_renderer_->GetMediaTime();
+}
+
+void End2EndTestRenderer::SendMessageToSink(
+    const std::vector<uint8_t>& message) {
+  std::unique_ptr<pb::RpcMessage> rpc(new pb::RpcMessage());
+  if (!rpc->ParseFromArray(message.data(), message.size())) {
+    VLOG(1) << __func__ << ": Received corrupted Rpc message.";
+    return;
+  }
+  receiver_rpc_broker_.ProcessMessageFromRemote(std::move(rpc));
+}
+
+void End2EndTestRenderer::SendFrameToSink(const std::vector<uint8_t>& frame,
+                                          DemuxerStream::Type type) {
+  if (frame.empty())

[miu, 2017/03/29 01:39:13]

Why do we check if the frame is empty? Feels like this might hide problems...

[xjz, 2017/03/30 23:21:30]

Done. Removed the check.

+    return;
+  scoped_refptr<DecoderBuffer> decoder_buffer =
+      ByteArrayToDecoderBuffer(frame.data(), frame.size());
+  receiver_->OnReceivedBuffer(type, decoder_buffer);
+}
+
+void End2EndTestRenderer::OnMessageFromSink(
+    std::unique_ptr<std::vector<uint8_t>> message) {
+  shared_session_->OnMessageFromSink(*message);
+}
+
+}  // namespace remoting
+}  // namespace media