Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 26925002: Add ccompute slaves for android buld slaves. (Closed)

Created:
7 years, 2 months ago by navabi
Modified:
7 years, 2 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add ccompute slaves for android buld slaves. Eventually, we want to replace the vm%d-m4.golo slaves with ccomputer instances. Before we do that, we need to get more ccompute instances. In the meantime, use ccompute instances along with the golo slaves. BUG=302063 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=228252

Patch Set 1 #

Total comments: 4

Patch Set 2 : slave%d-m4 --> slave%d-c4. #

Patch Set 3 : range(102, 120) --> range(102, 121) #

Patch Set 4 : Remove blink_android_compile_dbg, blink_android_compile_rel and android_x86_dbg from vm slaves. #

Patch Set 5 : Add back builders to vm slaves. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M masters/master.tryserver.chromium/slaves.cfg View 1 2 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
navabi1
7 years, 2 months ago (2013-10-10 21:18:19 UTC) #1
Ryan Tseng
https://codereview.chromium.org/26925002/diff/1/masters/master.tryserver.chromium/slaves.cfg File masters/master.tryserver.chromium/slaves.cfg (right): https://codereview.chromium.org/26925002/diff/1/masters/master.tryserver.chromium/slaves.cfg#newcode386 masters/master.tryserver.chromium/slaves.cfg:386: 'hostname': 'slave%d-m4' % i, s/m4/c4/ https://codereview.chromium.org/26925002/diff/1/masters/master.tryserver.chromium/slaves.cfg#newcode390 masters/master.tryserver.chromium/slaves.cfg:390: } for ...
7 years, 2 months ago (2013-10-10 21:20:17 UTC) #2
navabi
https://codereview.chromium.org/26925002/diff/1/masters/master.tryserver.chromium/slaves.cfg File masters/master.tryserver.chromium/slaves.cfg (right): https://codereview.chromium.org/26925002/diff/1/masters/master.tryserver.chromium/slaves.cfg#newcode386 masters/master.tryserver.chromium/slaves.cfg:386: 'hostname': 'slave%d-m4' % i, On 2013/10/10 21:20:17, Ryan T. ...
7 years, 2 months ago (2013-10-10 21:26:29 UTC) #3
Ryan Tseng
lgtm Let me know when it lands, I can start the slaves after that.
7 years, 2 months ago (2013-10-10 22:12:15 UTC) #4
Paweł Hajdan Jr.
LGTM
7 years, 2 months ago (2013-10-10 23:01:50 UTC) #5
navabi
On 2013/10/10 23:01:50, Paweł Hajdan Jr. wrote: > LGTM I added back the builders to ...
7 years, 2 months ago (2013-10-11 20:41:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/26925002/14001
7 years, 2 months ago (2013-10-11 20:41:38 UTC) #7
commit-bot: I haz the power
Presubmit check for 26925002-14001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 2 months ago (2013-10-11 20:42:10 UTC) #8
navabi
7 years, 2 months ago (2013-10-11 20:44:38 UTC) #9
Mike Stip (use stip instead)
lgtm
7 years, 2 months ago (2013-10-11 21:02:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/26925002/14001
7 years, 2 months ago (2013-10-11 21:11:06 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-11 21:11:51 UTC) #12
Message was sent while issue was closed.
Change committed as 228252

Powered by Google App Engine
This is Rietveld 408576698